Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1784833002: [counters] Put all counter work behind flags (Closed)

Created:
4 years, 9 months ago by Camillo Bruni
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[counters] Put all counter work behind flags Avoid creating and initializing timer scopes for builtins as well. BUG=chromium:589679 LOG=N Committed: https://crrev.com/1b67e9c86e7e1e54f4d6be96819912f03a7ff9b4 Cr-Commit-Position: refs/heads/master@{#34707}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M src/arguments.h View 1 chunk +1 line, -1 line 1 comment Download
M src/builtins.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Camillo Bruni
PTAL https://codereview.chromium.org/1784833002/diff/1/src/arguments.h File src/arguments.h (right): https://codereview.chromium.org/1784833002/diff/1/src/arguments.h#newcode281 src/arguments.h:281: Arguments args(args_length, args_object); \ apparently this has some ...
4 years, 9 months ago (2016-03-10 12:45:47 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-10 15:49:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784833002/1
4 years, 9 months ago (2016-03-11 08:13:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 08:43:12 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 08:43:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b67e9c86e7e1e54f4d6be96819912f03a7ff9b4
Cr-Commit-Position: refs/heads/master@{#34707}

Powered by Google App Engine
This is Rietveld 408576698