Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: test/cctest/wasm/test-run-wasm-64.cc

Issue 1784813004: X87: Change the test case for X87 Run_WasmF32SConvertI64/Run_WasmF64SConvertI64. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/wasm/test-run-wasm-64.cc
diff --git a/test/cctest/wasm/test-run-wasm-64.cc b/test/cctest/wasm/test-run-wasm-64.cc
index 79ed38645b5071b163e7290ff304b19f82016e4d..49f03e1a6dd97dc9995fe03fb0eaf3858574bf98 100644
--- a/test/cctest/wasm/test-run-wasm-64.cc
+++ b/test/cctest/wasm/test-run-wasm-64.cc
@@ -260,7 +260,10 @@ TEST(Run_WasmI64UConvertI32) {
TEST(Run_WasmF32SConvertI64) {
WasmRunner<float> r(MachineType::Int64());
BUILD(r, WASM_F32_SCONVERT_I64(WASM_GET_LOCAL(0)));
- FOR_INT64_INPUTS(i) { CHECK_EQ(static_cast<float>(*i), r.Call(*i)); }
+ FOR_INT64_INPUTS(i) {
+ volatile float expected = static_cast<float>(*i);
titzer 2016/03/16 09:44:51 Can you try the CHECK_DOUBLE_EQ macro?
+ CHECK_EQ(expected, r.Call(*i));
+ }
}
// kExprF32UConvertI64:
TEST(Run_WasmF32UConvertI64) {
@@ -353,7 +356,10 @@ TEST(Run_WasmF32UConvertI64) {
TEST(Run_WasmF64SConvertI64) {
WasmRunner<double> r(MachineType::Int64());
BUILD(r, WASM_F64_SCONVERT_I64(WASM_GET_LOCAL(0)));
- FOR_INT64_INPUTS(i) { CHECK_EQ(static_cast<double>(*i), r.Call(*i)); }
+ FOR_INT64_INPUTS(i) {
+ volatile double expected = static_cast<double>(*i);
+ CHECK_EQ(expected, r.Call(*i));
+ }
}
// kExprF64UConvertI64:
TEST(Run_Wasm_F64UConvertI64) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698