Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: components/version_info.gypi

Issue 1784783002: Remove obsolete override "ios_extra_version_path". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | components/version_info/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_info.gypi
diff --git a/components/version_info.gypi b/components/version_info.gypi
index 472f1d87be20f8ac6cd4dc87ff9f62e968c9b538..d81d85d3935c1d353d24936cd6e312af8ad09962 100644
--- a/components/version_info.gypi
+++ b/components/version_info.gypi
@@ -4,12 +4,6 @@
{
'variables': {
- # Some plaform want to override part of the version number generation
- # (for example iOS uses a different value for PATCH level for canary).
- # This can be done settings "extra_version_path" variable to the path
- # of a file with the corresponding value overrides. If present it will
- # be loaded after all other input files.
- 'extra_version_name': '',
'conditions': [
['branding == "Chrome"', {
'use_unofficial_version_number%': 0,
@@ -93,35 +87,8 @@
'<(template_input_path)',
'<@(_outputs)',
],
- 'conditions': [
- ['extra_version_name!=""', {
- 'variables': {
- 'extra_version_flags': [
- '-f', '<(extra_version_name)',
- ],
- },
- 'inputs': [
- '<(extra_version_name)'
- ],
- }],
- ],
},
],
},
],
- 'conditions': [
- ['OS=="ios"', {
- 'variables': {
- # Use nested 'variables' to workaround how variables work with gyp (no
- # determined ordering and thuse it is not possible to define a variable
- # in function of another).
- 'variables': {
- # Path to the file used to override the version PATH level on iOS.
- # Default to ios/build/util/VERSION.
- 'ios_extra_version_path%': '../ios/build/util/VERSION',
- },
- 'extra_version_name': '<(ios_extra_version_path)'
- },
- }],
- ],
}
« no previous file with comments | « DEPS ('k') | components/version_info/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698