Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1784763002: X87: [undetectable] Really get comparisons of document.all right now. (Closed)

Created:
4 years, 9 months ago by zhengxing.li
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [undetectable] Really get comparisons of document.all right now. port 679d9503cffe631cb3b938627274aea10893069c(r34608) original commit message: According to https://www.w3.org/TR/html5/obsolete.html#dom-document-all, comparisons of document.all to other values such as strings or objects, are unaffected. In fact document.all only gets special treatment in comparisons with null or undefined according to HTML. Especially setting the undetectable doesn't make two distinct JSReceivers equal. BUG= Committed: https://crrev.com/92eb11e95947103b8d948526417fa4d6ffbb3562 Cr-Commit-Position: refs/heads/master@{#34650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/x87/code-stubs-x87.cc View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 9 months ago (2016-03-10 02:45:10 UTC) #2
Weiliang
lgtm
4 years, 9 months ago (2016-03-10 05:51:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784763002/1
4 years, 9 months ago (2016-03-10 05:52:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 06:11:52 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 06:12:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92eb11e95947103b8d948526417fa4d6ffbb3562
Cr-Commit-Position: refs/heads/master@{#34650}

Powered by Google App Engine
This is Rietveld 408576698