[mojo-sdk] Remove mojo_ignore_result and move C++ macros.h to bindings internal code.

[mojo-sdk] Remove mojo_ignore_result and move C++ macros.h to bindings internal code.

The one macro remaining in macros.h is only used by generated C++ code.

BUG=534695
Committed: https://crrev.com/ecd73b09cccaaab72c859fef403ed489b7d1f174
Cr-Commit-Position: refs/heads/master@{#380556}

[Anand Mistry (off Chromium), 2016-03-10 06:11:35]

Description was changed from

==========
[mojo-sdk] Move C++ macros.h to bindings internal code.

The one macro defined in macros.h is only used by generated C++ code.

BUG=534695
==========

to

==========
[mojo-sdk] Remove mojo_ignore_result and move C++ macros.h to bindings internal
code.

The one macro remaining in macros.h is only used by generated C++ code.

BUG=534695
==========

[Anand Mistry (off Chromium), 2016-03-10 06:21:55]

amistry@chromium.org changed reviewers:
+ yzshen@chromium.org

[yzshen1, 2016-03-10 16:42:45]

On 2016/03/10 06:21:56, Anand Mistry wrote:

Considering that VS 2015 has arrived (mailing thread: [chromium-dev] PSA: VS
2015 is now default Windows compiler), is it possible that we delete
"mojo/public/cpp/bindings/lib/macros.h"?

Thanks!

[Anand Mistry (off Chromium), 2016-03-10 19:58:53]

On 2016/03/10 16:42:45, yzshen1 wrote:
> On 2016/03/10 06:21:56, Anand Mistry wrote:
> 
> Considering that VS 2015 has arrived (mailing thread: [chromium-dev] PSA: VS
> 2015 is now default Windows compiler), is it possible that we delete
> "mojo/public/cpp/bindings/lib/macros.h"?
> 
> Thanks!

That's been reverted. We can only get rid of it once we've declared VS2013 is no
longer supported, and that might be a few more months after VS2015 sticks.

[yzshen1, 2016-03-10 20:04:42]

On 2016/03/10 19:58:53, Anand Mistry wrote:
> On 2016/03/10 16:42:45, yzshen1 wrote:
> > On 2016/03/10 06:21:56, Anand Mistry wrote:
> > 
> > Considering that VS 2015 has arrived (mailing thread: [chromium-dev] PSA: VS
> > 2015 is now default Windows compiler), is it possible that we delete
> > "mojo/public/cpp/bindings/lib/macros.h"?
> > 
> > Thanks!
> 
> That's been reverted. We can only get rid of it once we've declared VS2013 is
no
> longer supported, and that might be a few more months after VS2015 sticks.

Yeah. It is unfortunate that it was reverted.

LGTM :)

[Anand Mistry (off Chromium), 2016-03-10 21:12:55]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2016-03-10 21:13:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784743003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784743003/40001

[commit-bot: I haz the power, 2016-03-10 21:27:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-10 21:27:28]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Anand Mistry (off Chromium), 2016-03-10 22:28:08]

amistry@chromium.org changed reviewers:
+ sky@chromium.org

[Anand Mistry (off Chromium), 2016-03-10 22:28:09]

sky: For components owners

[sky, 2016-03-10 22:46:07]

LGTM - feel free to TBR these sort of changes.

[Anand Mistry (off Chromium), 2016-03-10 22:56:45]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2016-03-10 22:56:46]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/1784743003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-03-10 22:57:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784743003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784743003/60001

[commit-bot: I haz the power, 2016-03-11 00:21:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 00:21:10]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Anand Mistry (off Chromium), 2016-03-11 00:32:42]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2016-03-11 00:33:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784743003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784743003/60001

[commit-bot: I haz the power, 2016-03-11 01:03:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 01:03:56]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Anand Mistry (off Chromium), 2016-03-11 01:29:14]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2016-03-11 01:29:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784743003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784743003/60001

[commit-bot: I haz the power, 2016-03-11 02:12:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 02:12:03]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Anand Mistry (off Chromium), 2016-03-11 04:43:25]

The CQ bit was checked by amistry@chromium.org

[commit-bot: I haz the power, 2016-03-11 04:43:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784743003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784743003/60001

[commit-bot: I haz the power, 2016-03-11 06:32:59]

Description was changed from

==========
[mojo-sdk] Remove mojo_ignore_result and move C++ macros.h to bindings internal
code.

The one macro remaining in macros.h is only used by generated C++ code.

BUG=534695
==========

to

==========
[mojo-sdk] Remove mojo_ignore_result and move C++ macros.h to bindings internal
code.

The one macro remaining in macros.h is only used by generated C++ code.

BUG=534695
==========

[commit-bot: I haz the power, 2016-03-11 06:33:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-11 06:34:26]

Description was changed from

==========
[mojo-sdk] Remove mojo_ignore_result and move C++ macros.h to bindings internal
code.

The one macro remaining in macros.h is only used by generated C++ code.

BUG=534695
==========

to

==========
[mojo-sdk] Remove mojo_ignore_result and move C++ macros.h to bindings internal
code.

The one macro remaining in macros.h is only used by generated C++ code.

BUG=534695

Committed: https://crrev.com/ecd73b09cccaaab72c859fef403ed489b7d1f174
Cr-Commit-Position: refs/heads/master@{#380556}
==========

[commit-bot: I haz the power, 2016-03-11 06:34:27]

Patchset 4 (id:??) landed as
https://crrev.com/ecd73b09cccaaab72c859fef403ed489b7d1f174
Cr-Commit-Position: refs/heads/master@{#380556}