Source/core/rendering/line/BreakingContextInlineHeaders.h - Issue 178473024: Convert some Shape code to use references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/line/BreakingContextInlineHeaders.h

Issue 178473024: Convert some Shape code to use references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebased patch Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/line/BreakingContextInlineHeaders.h

diff --git a/Source/core/rendering/line/BreakingContextInlineHeaders.h b/Source/core/rendering/line/BreakingContextInlineHeaders.h

index 9eb1187ca43ccd8d32a8e3458574ca150753d4c1..85fcce24ab3502aeb34719637e1a8134314e0c8a 100644

--- a/Source/core/rendering/line/BreakingContextInlineHeaders.h

+++ b/Source/core/rendering/line/BreakingContextInlineHeaders.h

@@ -516,7 +516,7 @@ inline void updateSegmentsForShapes(RenderBlockFlow* block, const FloatingObject

return;

bool isHorizontalWritingMode = block->isHorizontalWritingMode();

- LayoutUnit logicalOffsetFromShapeContainer = block->logicalOffsetFromShapeAncestorContainer(shapeInsideInfo->owner()).height();

+ LayoutUnit logicalOffsetFromShapeContainer = block->logicalOffsetFromShapeAncestorContainer(&shapeInsideInfo->owner()).height();

LayoutUnit lineLogicalTop = block->logicalHeight() + logicalOffsetFromShapeContainer;

LayoutUnit lineLogicalHeight = block->lineHeight(isFirstLine, isHorizontalWritingMode ? HorizontalLine : VerticalLine, PositionOfInteriorLineBoxes);

« no previous file with comments | « Source/core/rendering/RenderView.h ('k') | Source/core/rendering/line/LineWidth.cpp » ('j') | no next file with comments »