Issue 178473013: Merged r19599, r19591 into 3.24 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 178473013: Merged r19599, r19591 into 3.24 branch. (Closed)

Created:
6 years, 9 months ago by titzer

Modified:
6 years, 9 months ago

Reviewers:
Hannes Payer (out of office)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.24

Visibility:
Public.

Merged r19599, r19591 into 3.24 branch. Fix representation generalization for doubles. HAllocate should never generate allocation code if the requested size does not fit into page. Regression test included. BUG=347543 LOG=N R=hpayer@chromium.org, hpayer@google.com Committed: https://code.google.com/p/v8/source/detail?r=19633

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -23 lines)			Patch
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/property-details.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-347543.js	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A +	test/mjsunit/regress/regress-347909.js	View	1 chunk	+10 lines, -17 lines	0 comments	Download

Total messages: 4 (0 generated)

titzer

6 years, 9 months ago (2014-03-03 09:38:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19633 (tree was closed).