Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 1784723003: Migrate gpu_memory_buffer_factory_test_template to content/common/gpu (Closed)

Created:
4 years, 9 months ago by Mark Dittmer
Modified:
4 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate gpu_memory_buffer_factory_test_template to content/common/gpu Context: As part of a plan to move content/common/gpu out of content, we are eliminating deps from content/common/gpu to elsewhere in content. BUG=592254 Committed: https://crrev.com/dbdf20c9eec45a535156daf94b94db89ace868f5 Cr-Commit-Position: refs/heads/master@{#380511}

Patch Set 1 #

Patch Set 2 : Fix includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -105 lines) Patch
M content/common/gpu/gpu_memory_buffer_factory_io_surface_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_ozone_native_pixmap_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_memory_buffer_factory_surface_texture_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/common/gpu/gpu_memory_buffer_factory_test_template.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
D content/test/gpu_memory_buffer_factory_test_template.h View 1 chunk +0 lines, -98 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784723003/1
4 years, 9 months ago (2016-03-10 14:15:15 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/36503)
4 years, 9 months ago (2016-03-10 14:33:03 UTC) #6
Mark Dittmer
Fix includes
4 years, 9 months ago (2016-03-10 15:08:10 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784723003/20001
4 years, 9 months ago (2016-03-10 15:08:48 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-10 16:36:02 UTC) #11
Mark Dittmer
4 years, 9 months ago (2016-03-10 19:01:05 UTC) #12
piman
lgtm
4 years, 9 months ago (2016-03-10 21:02:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784723003/20001
4 years, 9 months ago (2016-03-11 01:52:10 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 05:12:24 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 05:13:24 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dbdf20c9eec45a535156daf94b94db89ace868f5
Cr-Commit-Position: refs/heads/master@{#380511}

Powered by Google App Engine
This is Rietveld 408576698