Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issue 1784723002: [Media Router] Removed selection box related to search input. (Closed)

Created:
4 years, 9 months ago by btolsch
Modified:
4 years, 9 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Removed selection box related to search input. This change removes the strange selection box artifact that could appear the user clicked in padding area of the search input. By changing the padding to a margin, the only clickable area is the actual text input. BUG=591969 R=apacible@chromium.org Committed: https://crrev.com/75a45c69a53a9bc4f1dd088b934fe13f4e3b873e Cr-Commit-Position: refs/heads/master@{#380372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
btolsch
I thought this was already out or was rolled into another change, but just I ...
4 years, 9 months ago (2016-03-10 00:54:44 UTC) #1
apacible
lgtm
4 years, 9 months ago (2016-03-10 01:13:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784723002/1
4 years, 9 months ago (2016-03-10 01:26:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/194277)
4 years, 9 months ago (2016-03-10 02:49:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784723002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784723002/1
4 years, 9 months ago (2016-03-10 06:31:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 07:44:32 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 07:45:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75a45c69a53a9bc4f1dd088b934fe13f4e3b873e
Cr-Commit-Position: refs/heads/master@{#380372}

Powered by Google App Engine
This is Rietveld 408576698