Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1784663002: Don't build CG on Linux CMake (Closed)

Created:
4 years, 9 months ago by msarett
Modified:
4 years, 9 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Don't build CG on Linux CMake BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1784663002 CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Committed: https://skia.googlesource.com/skia/+/fdd52c48bbeb779a39cdca0e1d38217ceb8874ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M cmake/CMakeLists.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ports/SkImageGeneratorCG.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784663002/1
4 years, 9 months ago (2016-03-09 22:52:21 UTC) #3
msarett
4 years, 9 months ago (2016-03-09 22:52:25 UTC) #5
robertphillips
lgtm
4 years, 9 months ago (2016-03-09 22:57:56 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 23:11:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784663002/1
4 years, 9 months ago (2016-03-09 23:11:40 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 23:12:35 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fdd52c48bbeb779a39cdca0e1d38217ceb8874ed

Powered by Google App Engine
This is Rietveld 408576698