Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: net/quic/quic_session.cc

Issue 1784643006: Deprecate FLAG_quic_block_unencrypted_writes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@115904466
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/tools/quic/quic_client_session_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_session.cc
diff --git a/net/quic/quic_session.cc b/net/quic/quic_session.cc
index d8ec06c2f21273da9eb764c6eb96fba5fbcd0169..dd3893e716b2a066e9fac31bf448eb0dcdc49f5b 100644
--- a/net/quic/quic_session.cc
+++ b/net/quic/quic_session.cc
@@ -241,8 +241,7 @@ QuicConsumedData QuicSession::WritevData(
bool fin,
FecProtection fec_protection,
QuicAckListenerInterface* ack_notifier_delegate) {
- if (FLAGS_quic_block_unencrypted_writes && !IsEncryptionEstablished() &&
- id != kCryptoStreamId) {
+ if (!IsEncryptionEstablished() && id != kCryptoStreamId) {
// Do not let streams write without encryption. The calling stream will end
// up write blocked until OnCanWrite is next called.
return QuicConsumedData(0, false);
@@ -530,9 +529,7 @@ void QuicSession::OnCryptoHandshakeEvent(CryptoHandshakeEvent event) {
// to QuicSession since it is the glue.
case ENCRYPTION_FIRST_ESTABLISHED:
// Given any streams blocked by encryption a chance to write.
- if (FLAGS_quic_block_unencrypted_writes) {
- OnCanWrite();
- }
+ OnCanWrite();
break;
case ENCRYPTION_REESTABLISHED:
@@ -540,9 +537,7 @@ void QuicSession::OnCryptoHandshakeEvent(CryptoHandshakeEvent event) {
// decrypted by the peer.
connection_->RetransmitUnackedPackets(ALL_INITIAL_RETRANSMISSION);
// Given any streams blocked by encryption a chance to write.
- if (FLAGS_quic_block_unencrypted_writes) {
- OnCanWrite();
- }
+ OnCanWrite();
break;
case HANDSHAKE_CONFIRMED:
« no previous file with comments | « net/quic/quic_flags.cc ('k') | net/tools/quic/quic_client_session_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698