Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1784633002: Fix "[turbofan] [deoptimizer] Support inlining of ES6 tail calls" for embedded constant pools. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix "[turbofan] [deoptimizer] Support inlining of ES6 tail calls" for embedded constant pools. Correct handling of the bottom frame in DoComputeArgumentsAdaptorFrame. R=ishell@chromium.org, jarin@chromium.org, michael_dawson@ca.ibm.com BUG=v8:4698 LOG=N Committed: https://crrev.com/01589fe708d623353158dcea857cc0cf660ff49e Cr-Commit-Position: refs/heads/master@{#34681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/deoptimizer.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-09 22:38:15 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784633002/1
4 years, 9 months ago (2016-03-09 22:38:27 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 23:14:48 UTC) #5
Jarin
lgtm. Thanks for the fix!
4 years, 9 months ago (2016-03-10 07:43:36 UTC) #6
Igor Sheludko
On 2016/03/10 07:43:36, Jarin wrote: > lgtm. Thanks for the fix! Thanks!
4 years, 9 months ago (2016-03-10 07:59:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784633002/1
4 years, 9 months ago (2016-03-10 15:04:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 15:05:57 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 15:07:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01589fe708d623353158dcea857cc0cf660ff49e
Cr-Commit-Position: refs/heads/master@{#34681}

Powered by Google App Engine
This is Rietveld 408576698