Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 178463007: Moved type feedback vector to SharedFunctionInfo. (Closed)

Created:
6 years, 9 months ago by mvstanton
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Moved type feedback vector to SharedFunctionInfo. Type Vector followup: the type vector currently lives off the code object. This CL moves it to the SharedFunctionInfo, facilitating re-use and continued use in crankshafted code if desired. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19712

Patch Set 1 : reattempt #

Patch Set 2 : Removed wrong code. #

Patch Set 3 : Ports and comment response. #

Total comments: 16

Patch Set 4 : Comments response. #

Patch Set 5 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -140 lines) Patch
M src/a64/full-codegen-a64.cc View 1 2 3 4 4 chunks +1 line, -13 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 chunks +1 line, -13 lines 0 comments Download
M src/compiler.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 2 3 4 5 chunks +29 lines, -2 lines 0 comments Download
M src/factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/factory.cc View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M src/full-codegen.h View 1 2 3 4 2 chunks +1 line, -6 lines 0 comments Download
M src/full-codegen.cc View 1 2 3 4 3 chunks +2 lines, -14 lines 0 comments Download
M src/heap.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 4 chunks +1 line, -14 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 3 4 4 chunks +1 line, -13 lines 0 comments Download
M src/objects.h View 1 2 3 4 7 chunks +13 lines, -11 lines 0 comments Download
M src/objects.cc View 1 2 3 4 1 chunk +10 lines, -13 lines 0 comments Download
M src/objects-debug.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 2 3 4 3 chunks +3 lines, -5 lines 0 comments Download
M src/objects-printer.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-visiting-inl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M src/type-info.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/type-info.cc View 1 2 2 chunks +6 lines, -10 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 chunks +1 line, -14 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 2 3 4 1 chunk +34 lines, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mvstanton
Hi Benedikt, could you have a look? Thanks! --Michael
6 years, 9 months ago (2014-03-03 16:47:19 UTC) #1
Benedikt Meurer
As mentioned offline, make sure to not clear existing type feedback when full codegen is ...
6 years, 9 months ago (2014-03-04 10:02:50 UTC) #2
mvstanton
Hi Benedikt, Good advice. I have a new test, and was generally able to extract ...
6 years, 9 months ago (2014-03-04 13:50:12 UTC) #3
Benedikt Meurer
Since this is unrelated to the SharedFunctionInfo move, can we please split this into two ...
6 years, 9 months ago (2014-03-05 06:23:57 UTC) #4
Benedikt Meurer
Hey Michael, As discussed offline, it makes sense to keep this as one single CL. ...
6 years, 9 months ago (2014-03-05 07:22:55 UTC) #5
mvstanton
Thx for the review/discussion, here are updates, --Michael https://codereview.chromium.org/178463007/diff/80001/src/compiler.cc File src/compiler.cc (right): https://codereview.chromium.org/178463007/diff/80001/src/compiler.cc#newcode264 src/compiler.cc:264: *TypeFeedbackInfo::UninitializedSentinel(isolate())); ...
6 years, 9 months ago (2014-03-05 08:48:02 UTC) #6
Benedikt Meurer
LGTM
6 years, 9 months ago (2014-03-05 11:32:24 UTC) #7
mvstanton
6 years, 9 months ago (2014-03-07 10:12:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #5 manually as r19712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698