Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1784623006:
X87: Rework CallApi*Stubs. (Closed)
|
Created:
4 years, 9 months ago by zhengxing.li Modified:
4 years, 9 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionX87: Rework CallApi*Stubs.
port 5096492f1b0460b2644c7f79f9ccc5881fc65c50 (r34627)
original commit message:
- Eliminate stubs with a variable number of arguments.
(That only worked due to their very limited use. These
stubs' interface descriptors were basically lying
about their number of args, which will fail when used
generically.)
- Fix all CallApi*Stubs' interface descriptors to no
longer lie about their arguments.
- Unify CallApi*Stub, for * in Function, Accessor,
FunctionWithFixedArgs.
(Since these are now all doing the same thing.)
- Rename the unified stub (and interface descriptors) to
*ApiCallback*, since that's really what they're doing.
- Refuse inlining an API callback if its number of
parameters exceeds the supported number of args.
BUG=
Committed: https://crrev.com/b8f49a273bd1b26e47ee1f57e48945b31fb85f53
Cr-Commit-Position: refs/heads/master@{#34700}
Patch Set 1 #
Messages
Total messages: 21 (9 generated)
zhengxing.li@intel.com changed reviewers: + chunyang.dai@intel.com, vogelheim@chromium.org, weiliang.lin@intel.com
PTAL, thanks!
lgtm
lgtm
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784623006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784623006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...) v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compil...)
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784623006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784623006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compil...)
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784623006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784623006/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_win_compile_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/1...) v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compil...)
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784623006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784623006/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
X87: Rework CallApi*Stubs.
port 5096492f1b0460b2644c7f79f9ccc5881fc65c50 (r34627)
original commit message:
- Eliminate stubs with a variable number of arguments.
(That only worked due to their very limited use. These
stubs' interface descriptors were basically lying
about their number of args, which will fail when used
generically.)
- Fix all CallApi*Stubs' interface descriptors to no
longer lie about their arguments.
- Unify CallApi*Stub, for * in Function, Accessor,
FunctionWithFixedArgs.
(Since these are now all doing the same thing.)
- Rename the unified stub (and interface descriptors) to
*ApiCallback*, since that's really what they're doing.
- Refuse inlining an API callback if its number of
parameters exceeds the supported number of args.
BUG=
==========
to
==========
X87: Rework CallApi*Stubs.
port 5096492f1b0460b2644c7f79f9ccc5881fc65c50 (r34627)
original commit message:
- Eliminate stubs with a variable number of arguments.
(That only worked due to their very limited use. These
stubs' interface descriptors were basically lying
about their number of args, which will fail when used
generically.)
- Fix all CallApi*Stubs' interface descriptors to no
longer lie about their arguments.
- Unify CallApi*Stub, for * in Function, Accessor,
FunctionWithFixedArgs.
(Since these are now all doing the same thing.)
- Rename the unified stub (and interface descriptors) to
*ApiCallback*, since that's really what they're doing.
- Refuse inlining an API callback if its number of
parameters exceeds the supported number of args.
BUG=
Committed: https://crrev.com/b8f49a273bd1b26e47ee1f57e48945b31fb85f53
Cr-Commit-Position: refs/heads/master@{#34700}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b8f49a273bd1b26e47ee1f57e48945b31fb85f53 Cr-Commit-Position: refs/heads/master@{#34700} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
