Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: base/win/windows_version.h

Issue 1784623003: Add histograms to compare GetVersionEx() with VerQueryValue() of kernel32 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/win/windows_version.cc » ('j') | base/win/windows_version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/windows_version.h
diff --git a/base/win/windows_version.h b/base/win/windows_version.h
index 676bd979578b9fc07b83bed55d6d5257650858c8..86f93bb5183616f9fa2cf499e5f46a4ae3333ebf 100644
--- a/base/win/windows_version.h
+++ b/base/win/windows_version.h
@@ -86,6 +86,7 @@ class BASE_EXPORT OSInfo {
static OSInfo* GetInstance();
Version version() const { return version_; }
+ Version kernel32_version() const { return kernel32_version_; }
Will Harris 2016/03/09 23:02:50 how are none of these functions commented...? :)
scottmg 2016/03/10 00:41:31 Doesn't seem like comments would be very useful.
// The next two functions return arrays of values, [major, minor(, build)].
VersionNumber version_number() const { return version_number_; }
VersionType version_type() const { return version_type_; }
@@ -105,6 +106,7 @@ class BASE_EXPORT OSInfo {
~OSInfo();
Version version_;
+ Version kernel32_version_;
VersionNumber version_number_;
VersionType version_type_;
ServicePack service_pack_;
« no previous file with comments | « no previous file | base/win/windows_version.cc » ('j') | base/win/windows_version.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698