tools/metrics/histograms/histograms.xml - Issue 1784623003: Add histograms to compare GetVersionEx() with VerQueryValue() of kernel32

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1784623003: Add histograms to compare GetVersionEx() with VerQueryValue() of kernel32 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

« chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc ('K') | « chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index b3254d053aafffeb337289c6eb193171b231ee36..6682769916f607d44716e0de6a89512d9290107c 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -58468,6 +58468,30 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Windows.GetVersionExVersion" enum="WindowsVersion">

+ <owner>scottmg@chromium.org</owner>

+ <summary>

+ The Windows version (base::win::Version) as reported by GetVersionEx().

Alexei Svitkine (slow) 2016/03/11 20:16:51 Nit: For all of these, mention when this is logged

scottmg 2016/03/11 22:44:26 Done.

+ </summary>

+</histogram>

+<histogram name="Windows.InCompatibilityMode" enum="Boolean">

Alexei Svitkine (slow) 2016/03/11 20:16:51 Nit: Use a more specific boolean, like BooleanMatc

scottmg 2016/03/11 22:44:26 Done.

+ <owner>scottmg@chromium.org</owner>

+ <summary>

+ A boolean used to indicate when the Windows version reported by

+ GetVersionEx() and the Windows version reported by VerQueryValue() on

+ kernel32 do not match.

+ </summary>

+</histogram>

+<histogram name="Windows.Kernel32Version" enum="WindowsVersion">

+ <owner>scottmg@chromium.org</owner>

+ <summary>

+ The Windows version (base::win::Version) as reported by VeryQueryValue() on

+ kernel32.dll.

+ </summary>

+</histogram>

<owner>zturner@chromium.org</owner>

<summary>Count of browser launches from a Windows tablet pc.</summary>

@@ -84184,6 +84208,9 @@ To add a new entry, add it with any value and run test to compute valid value.

+ <int value="6" label="Windows 8.1"/>

+ <int value="7" label="Windows 10"/>

+ <int value="8" label="Windows 10 TH2"/>

</enum>