tools/metrics/histograms/histograms.xml - Issue 1784623003: Add histograms to compare GetVersionEx() with VerQueryValue() of kernel32

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1784623003: Add histograms to compare GetVersionEx() with VerQueryValue() of kernel32 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 5e334167a6657c475f9f07d0e104dc6233e13b05..8c56c55dd3be164fd1f632bffc5d53d2c62f5192 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -58379,6 +58379,30 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="Windows.GetVersionExVersion" enum="WindowsVersion">

+ <owner>scottmg@chromium.org</owner>

+ <summary>

+ The Windows version (base::win::Version) as reported by GetVersionEx().

+ </summary>

+</histogram>

+<histogram name="Windows.InCompatibilityMode">

Will Harris 2016/03/09 23:02:50 I think you need a enum="Boolean*" type e.g. Boole

scottmg 2016/03/10 00:41:31 I copied from some other bools, dunno. Maybe it ju

+ <owner>scottmg@chromium.org</owner>

+ <summary>

+ A boolean used to indicate when the Windows version reported by

+ GetVersionEx() and the Windows version reported by VerQueryValue() on

+ kernel32 do not match.

+ </summary>

+</histogram>

+<histogram name="Windows.Kernel32Version" enum="WindowsVersion">

+ <owner>scottmg@chromium.org</owner>

+ <summary>

+ The Windows version (base::win::Version) as reported by VeryQueryValue() on

+ kernel32.dll.

+ </summary>

+</histogram>

<owner>zturner@chromium.org</owner>

<summary>Count of browser launches from a Windows tablet pc.</summary>

@@ -84044,6 +84068,9 @@ To add a new entry, add it with any value and run test to compute valid value.

+ <int value="6" label="Windows 8.1"/>

+ <int value="7" label="Windows 10"/>

+ <int value="8" label="Windows 10 TH2"/>

</enum>

« content/browser/browser_main_loop.cc ('K') | « content/browser/browser_main_loop.cc ('k') | no next file » | no next file with comments »