Add histograms to compare GetVersionEx() with VerQueryValue() of kernel32

content/browser/browser_main_loop.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_main_loop.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 113 matching lines @@
 #include "ui/ozone/public/client_native_pixmap_factory.h"
 #include "ui/ozone/public/ozone_platform.h"
 #endif
 
 #if defined(OS_WIN)
 #include <windows.h>
 #include <commctrl.h>
 #include <shellapi.h>
 
 #include "base/memory/memory_pressure_monitor_win.h"
+#include "base/win/windows_version.h"
 #include "content/common/sandbox_win.h"
 #include "net/base/winsock_init.h"
 #include "ui/base/l10n/l10n_util_win.h"
 #endif
 
 #if defined(OS_CHROMEOS)
 #include "base/memory/memory_pressure_monitor_chromeos.h"
 #include "chromeos/chromeos_switches.h"
 #endif
 
@@ skipping 544 matching lines @@
   // Enable memory-infra dump providers.
   InitSkiaEventTracer();
   tracing::ProcessMetricsMemoryDumpProvider::RegisterForProcess(
       base::kNullProcessId);
   base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
       HostSharedBitmapManager::current(), "HostSharedBitmapManager", nullptr);
   base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
       skia::SkiaMemoryDumpProvider::GetInstance(), "Skia", nullptr);
   base::trace_event::MemoryDumpManager::GetInstance()->RegisterDumpProvider(
       sql::SqlMemoryDumpProvider::GetInstance(), "Sql", nullptr);
+
+#if defined(OS_WIN)
+  UMA_HISTOGRAM_ENUMERATION("Windows.GetVersionExVersion",
+                            base::win::OSInfo::GetInstance()->version(),
+                            base::win::VERSION_WIN_LAST);
+  UMA_HISTOGRAM_ENUMERATION(
+      "Windows.Kernel32Version",
+      base::win::OSInfo::GetInstance()->kernel32_version(),

[Will Harris, 2016/03/09 23:02:50]

given this call can loadlibrary, should it be moved off the hotpath for startup
e.g. into a posttaskwithdelay?

[scottmg, 2016/03/10 00:41:31]

Done. (It wouldn't have done IO here before, but now it will since
Kernel32Version() retrieves on demand)

+      base::win::VERSION_WIN_LAST);
+  UMA_HISTOGRAM_BOOLEAN(
+      "Windows.InCompatibilityMode",
+      base::win::OSInfo::GetInstance()->version() !=
+          base::win::OSInfo::GetInstance()->kernel32_version());
+#endif  // OS_WIN
 }
 
 int BrowserMainLoop::PreCreateThreads() {
   if (parts_) {
     TRACE_EVENT0("startup",
         "BrowserMainLoop::CreateThreads:PreCreateThreads");
     TRACK_SCOPED_REGION("Startup", "BrowserMainLoop::PreCreateThreads");
 
     result_code_ = parts_->PreCreateThreads();
   }
@@ skipping 758 matching lines @@
   DCHECK(is_tracing_startup_for_duration_);
 
   is_tracing_startup_for_duration_ = false;
   TracingController::GetInstance()->StopTracing(
       TracingController::CreateFileSink(
           startup_trace_file_,
           base::Bind(OnStoppedStartupTracing, startup_trace_file_)));
 }
 
 }  // namespace content