Fix timestamp sent from CanvasCaptureHandler & make thread checkers clear

Fix timestamp sent from CanvasCaptureHandler & make thread checkers clear

This CL adresses issues caused by the missing timestamp in the
VideoFrame sent from CanvasCaptureHandler. We send
base::TimeTicks::Now() as other capture devices do[0][1].

Also, thread checkers are named according to the threads they are
pinned to.

[0] https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/media/capture/desktop_capture_device.cc&rcl=1457541024&l=316
[1] https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/video/linux/v4l2_capture_delegate.cc&rcl=1457541024&l=395

BUG=524218
Committed: https://crrev.com/db1ec30aabfc9e826f143a20dc7f1c3e9df1325b
Cr-Commit-Position: refs/heads/master@{#380323}

[emircan, 2016-03-09 21:58:33]

Description was changed from

==========
quick fix.

BUG=
==========

to

==========
Fix timestamp sent from CanvasCaptureHandler

This CL adresses issues caused by the missing timestamp in the
VideoFrame sent from CanvasCaptureHandler. We send 
base::TimeTicks::Now() as other capture devices do[0][1].

[0]
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/vide...
==========

[emircan, 2016-03-09 22:07:24]

Patchset #1 (id:1) has been deleted

[emircan, 2016-03-09 22:07:48]

emircan@chromium.org changed reviewers:
+ mcasas@chromium.org

[emircan, 2016-03-09 22:07:48]

PTAL.

[mcasas, 2016-03-09 22:30:13]

lgtm

[emircan, 2016-03-09 23:49:30]

Patchset #2 (id:40001) has been deleted

[emircan, 2016-03-09 23:50:44]

Thanks. I went over the class and renamed thread_checkers to make it clear which
thread they are specified on.

[mcasas, 2016-03-10 00:25:45]

On 2016/03/09 23:50:44, emircan wrote:
> Thanks. I went over the class and renamed thread_checkers to make it clear
which
> thread they are specified on.

Hmm still LGTM  (please update CL description as well).

[emircan, 2016-03-10 02:39:12]

Description was changed from

==========
Fix timestamp sent from CanvasCaptureHandler

This CL adresses issues caused by the missing timestamp in the
VideoFrame sent from CanvasCaptureHandler. We send 
base::TimeTicks::Now() as other capture devices do[0][1].

[0]
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/vide...
==========

to

==========
Fix timestamp sent from CanvasCaptureHandler & make thread checkers clear

This CL adresses issues caused by the missing timestamp in the
VideoFrame sent from CanvasCaptureHandler. We send 
base::TimeTicks::Now() as other capture devices do[0][1].

Also, thread checkers are named according to the threads they are 
pinned to.

[0]
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/vide...
==========

[emircan, 2016-03-10 02:39:54]

Description was changed from

==========
Fix timestamp sent from CanvasCaptureHandler & make thread checkers clear

This CL adresses issues caused by the missing timestamp in the
VideoFrame sent from CanvasCaptureHandler. We send 
base::TimeTicks::Now() as other capture devices do[0][1].

Also, thread checkers are named according to the threads they are 
pinned to.

[0]
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/vide...
==========

to

==========
Fix timestamp sent from CanvasCaptureHandler & make thread checkers clear

This CL adresses issues caused by the missing timestamp in the
VideoFrame sent from CanvasCaptureHandler. We send 
base::TimeTicks::Now() as other capture devices do[0][1].

Also, thread checkers are named according to the threads they are 
pinned to.

[0]
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/vide...

BUG=524218
==========

[emircan, 2016-03-10 02:40:02]

The CQ bit was checked by emircan@chromium.org

[commit-bot: I haz the power, 2016-03-10 02:40:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1784603002/50004
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1784603002/50004

[commit-bot: I haz the power, 2016-03-10 03:47:42]

Description was changed from

==========
Fix timestamp sent from CanvasCaptureHandler & make thread checkers clear

This CL adresses issues caused by the missing timestamp in the
VideoFrame sent from CanvasCaptureHandler. We send 
base::TimeTicks::Now() as other capture devices do[0][1].

Also, thread checkers are named according to the threads they are 
pinned to.

[0]
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/vide...

BUG=524218
==========

to

==========
Fix timestamp sent from CanvasCaptureHandler & make thread checkers clear

This CL adresses issues caused by the missing timestamp in the
VideoFrame sent from CanvasCaptureHandler. We send 
base::TimeTicks::Now() as other capture devices do[0][1].

Also, thread checkers are named according to the threads they are 
pinned to.

[0]
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/vide...

BUG=524218
==========

[commit-bot: I haz the power, 2016-03-10 03:47:43]

Committed patchset #2 (id:50004)

[commit-bot: I haz the power, 2016-03-10 03:50:08]

Description was changed from

==========
Fix timestamp sent from CanvasCaptureHandler & make thread checkers clear

This CL adresses issues caused by the missing timestamp in the
VideoFrame sent from CanvasCaptureHandler. We send 
base::TimeTicks::Now() as other capture devices do[0][1].

Also, thread checkers are named according to the threads they are 
pinned to.

[0]
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/vide...

BUG=524218
==========

to

==========
Fix timestamp sent from CanvasCaptureHandler & make thread checkers clear

This CL adresses issues caused by the missing timestamp in the
VideoFrame sent from CanvasCaptureHandler. We send
base::TimeTicks::Now() as other capture devices do[0][1].

Also, thread checkers are named according to the threads they are
pinned to.

[0]
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/media/capture/vide...

BUG=524218

Committed: https://crrev.com/db1ec30aabfc9e826f143a20dc7f1c3e9df1325b
Cr-Commit-Position: refs/heads/master@{#380323}
==========

[commit-bot: I haz the power, 2016-03-10 03:50:09]

Patchset 2 (id:??) landed as
https://crrev.com/db1ec30aabfc9e826f143a20dc7f1c3e9df1325b
Cr-Commit-Position: refs/heads/master@{#380323}

[Lei Zhang, 2016-03-10 21:44:02]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-03-10 21:44:02]

https://codereview.chromium.org/1784603002/diff/50004/content/renderer/media/...
File content/renderer/media/canvas_capture_handler_unittest.cc (right):

https://codereview.chromium.org/1784603002/diff/50004/content/renderer/media/...
content/renderer/media/canvas_capture_handler_unittest.cc:103:
EXPECT_EQ(video_frame->timestamp().InMilliseconds(),
This has been failing on memory.fyi bots, e.g.

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28...