Better single stepping in VM debugger

runtime/vm/stub_code_arm.cc

Index: runtime/vm/stub_code_arm.cc
===================================================================
--- runtime/vm/stub_code_arm.cc	(revision 24600)
+++ runtime/vm/stub_code_arm.cc	(working copy)
@@ -1399,6 +1399,19 @@
   }
 #endif  // DEBUG
 
+  // Check single stepping.
+  Label not_stepping;
+  __ ldr(R6, FieldAddress(CTX, Context::isolate_offset()));
+  __ ldrb(R6, Address(R6, Isolate::single_step_offset()));
+  __ CompareImmediate(R6, 0);
+  __ b(&not_stepping, EQ);
+  __ EnterStubFrame();
+  __ Push(R5);  // Preserve IC data.
+  __ CallRuntime(kSingleStepHandlerRuntimeEntry);
+  __ Pop(R5);
+  __ LeaveStubFrame();
+  __ Bind(&not_stepping);
+
   // Load arguments descriptor into R4.
   __ ldr(R4, FieldAddress(R5, ICData::arguments_descriptor_offset()));
   // Preserve return address, since LR is needed for subroutine call.
@@ -1614,6 +1627,19 @@
   }
 #endif  // DEBUG
 
+  // Check single stepping.
+  Label not_stepping;
+  __ ldr(R6, FieldAddress(CTX, Context::isolate_offset()));
+  __ ldrb(R6, Address(R6, Isolate::single_step_offset()));
+  __ CompareImmediate(R6, 0);
+  __ b(&not_stepping, EQ);
+  __ EnterStubFrame();
+  __ Push(R5);  // Preserve IC data.
+  __ CallRuntime(kSingleStepHandlerRuntimeEntry);
+  __ Pop(R5);
+  __ LeaveStubFrame();
+  __ Bind(&not_stepping);

[siva, 2013/07/01 17:04:48]

why not abstract this into a private function
StubCode::CheckForSingleStepping(Register tmp, bool preserve_ic_data);
Would avoid code duplication.

Here and in the other targets too.

[hausner, 2013/08/09 09:59:02]

I'll do that in a separate checkin once I add more places where we do this
check. Good idea.

+
   // R5: IC data object (preserved).
   __ ldr(R6, FieldAddress(R5, ICData::ic_data_offset()));
   // R6: ic_data_array with entries: target functions and count.
@@ -2050,6 +2076,17 @@
 // Return Zero condition flag set if equal.
 void StubCode::GenerateUnoptimizedIdenticalWithNumberCheckStub(
     Assembler* assembler) {
+  // Check single stepping.
+  Label not_stepping;
+  __ ldr(R1, FieldAddress(CTX, Context::isolate_offset()));
+  __ ldrb(R1, Address(R1, Isolate::single_step_offset()));
+  __ CompareImmediate(R1, 0);
+  __ b(&not_stepping, EQ);
+  __ EnterStubFrame();
+  __ CallRuntime(kSingleStepHandlerRuntimeEntry);
+  __ LeaveStubFrame();
+  __ Bind(&not_stepping);
+
   const Register temp = R2;
   const Register left = R1;
   const Register right = R0;