media/video/capture/video_capture_device_unittest.cc - Issue 17846002: Refactor the VideoCaptureDevice::Name struct.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/video_capture_device_unittest.cc

Issue 17846002: Refactor the VideoCaptureDevice::Name struct. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/video/capture/video_capture_device_unittest.cc

diff --git a/media/video/capture/video_capture_device_unittest.cc b/media/video/capture/video_capture_device_unittest.cc

index fb0683df7c7b727c5af51077a82677d9ae9449a7..696c51c4e79ecb6e2c4b95e9cf8efda259a4e8c5 100644

--- a/media/video/capture/video_capture_device_unittest.cc

+++ b/media/video/capture/video_capture_device_unittest.cc

@@ -127,9 +127,7 @@ class VideoCaptureDeviceTest : public testing::Test {

};

TEST_F(VideoCaptureDeviceTest, OpenInvalidDevice) {

- VideoCaptureDevice::Name device_name;

- device_name.device_name = "jibberish";

- device_name.unique_id = "jibberish";

+ VideoCaptureDevice::Name device_name("jibberish", "jibberish");

VideoCaptureDevice* device = VideoCaptureDevice::Create(device_name);

EXPECT_TRUE(device == NULL);

}