Refactor the VideoCaptureDevice::Name struct.

media/video/capture/video_capture_device.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // VideoCaptureDevice is the abstract base class for realizing video capture
 // device support in Chromium. It provides the interface for OS dependent
 // implementations.
 // The class is created and functions are invoked on a thread owned by
 // VideoCaptureManager. Capturing is done on other threads, depending on the OS
 // specific implementation.
 
 #ifndef MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_H_
 #define MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_H_
 
 #include <list>
 #include <string>
 
 #include "base/time.h"
 #include "media/base/media_export.h"
 #include "media/video/capture/video_capture_types.h"
 
 namespace media {
 
 class MEDIA_EXPORT VideoCaptureDevice {
  public:
+  // Represents a capture device name and ID.
+  // You should not create an instance of this class directly by e.g. setting
+  // various properties directly.  Instead use
+  // VideoCaptureDevice::GetDeviceNames to do this for you and if you need to
+  // cache your own copy of a name, you can do so via the copy constructor.
+  // The reason for this is that a device name might contain platform specific
+  // settings that are relevant only to the platform specific implementation of
+  // VideoCaptureDevice::Create.
+  class Name {
+   public:
+    Name() {}
+    Name(const std::string& name, const std::string& id)
+        : device_name_(name), unique_id_(id) {}
+    // Allow a copy constructor since this type is used in stl containers
+    // and copied to members.
+    Name(const Name& other)
+        : device_name_(other.device_name_), unique_id_(other.unique_id_) {}
 
-  struct Name {
+    ~Name() {}
+
     // Friendly name of a device
-    std::string device_name;
+    const std::string& name() const { return device_name_; }
 
     // Unique name of a device. Even if there are multiple devices with the same
     // friendly name connected to the computer this will be unique.
-    std::string unique_id;
+    const std::string& id() const { return unique_id_; }
+
+   private:
+    std::string device_name_;
+    std::string unique_id_;
   };
-  typedef std::list<Name> Names;
+
+  // Manages a list of Name entries.
+  class Names : public std::list<Name> {
+   public:
+    Names() {}
+
+    // Returns NULL if no entry was found by that ID.
+    Name* FindById(const std::string& id) {

[wjia(left Chromium), 2013/06/26 18:16:44]

Do you need an inline function here? If not, it's better move this one into cc
file to cut compile time. Same applies above.

[tommi (sloooow) - chröme, 2013/07/01 13:32:30]

Sorry, missed this in the last round.  Added a new file.

+      for (iterator it = begin(); it != end(); ++it) {
+        if (it->id() == id)
+          return &(*it);
+      }
+      return NULL;
+    }
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(Names);
+  };
 
   class MEDIA_EXPORT EventHandler {
    public:
 
     // Reserve an output buffer into which a video frame can be captured
     // directly. If all buffers are currently busy, returns NULL.
     //
     // The returned VideoFrames will always be allocated with a YV12 format. The
     // size will match that specified by an earlier call to OnFrameInfo. It is
     // the VideoCaptureDevice's responsibility to obey whatever stride and
@@ skipping 87 matching lines @@
   // not permitted to make any additional calls to its EventHandler.
   virtual void DeAllocate() = 0;
 
   // Get the name of the capture device.
   virtual const Name& device_name() = 0;
 };
 
 }  // namespace media
 
 #endif  // MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_DEVICE_H_