third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp - Issue 1784583002: PushEvent.data should be NULL for empty payloads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

Issue 1784583002: PushEvent.data should be NULL for empty payloads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moar redness Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp b/third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

index 82ee42eab9fd04f348a4ddca58e43030f2c968fd..d0c05b30cabed06bbc945312566938d1aaa3353e 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

+++ b/third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

@@ -36,9 +36,6 @@ const AtomicString& PushEvent::interfaceName() const

PushMessageData* PushEvent::data()

{

- if (!m_data)

- m_data = PushMessageData::create();

return m_data.get();

}