PushEvent.data should be NULL for empty payloads

third_party/WebKit/Source/modules/push_messaging/PushEvent.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/push_messaging/PushEvent.h"
 
 #include "modules/push_messaging/PushEventInit.h"
 
 namespace blink {
 
 PushEvent::PushEvent()
+    : m_data(PushMessageData::create())

[dgn, 2016/03/09 21:22:25]

Isn't that always creating empty data? shouldn't it be create with a null
string? or leave it null? 
The description does not match currently.

[Peter Beverloo, 2016/03/09 21:28:29]

There's one call-site that can return a nullptr immediately indeed, so I removed
this.

 {
 }
 
 PushEvent::PushEvent(const AtomicString& type, PushMessageData* data, WaitUntilObserver* observer)
     : ExtendableEvent(type, ExtendableEventInit(), observer)
     , m_data(data)
 {
 }
 
 PushEvent::PushEvent(const AtomicString& type, const PushEventInit& initializer)
     : ExtendableEvent(type, initializer)
 {
     if (initializer.hasData())
         m_data = PushMessageData::create(initializer.data());
 }
 
 PushEvent::~PushEvent()
 {
 }
 
 const AtomicString& PushEvent::interfaceName() const
 {
     return EventNames::PushEvent;
 }
 
 PushMessageData* PushEvent::data()
 {
-    if (!m_data)
-        m_data = PushMessageData::create();
-
     return m_data.get();
 }
 
 DEFINE_TRACE(PushEvent)
 {
     visitor->trace(m_data);
     ExtendableEvent::trace(visitor);
 }
 
 } // namespace blink