Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1784573002: mus: Client-side implementation of modal windows (Closed)

Created:
4 years, 9 months ago by mohsen
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@b548402_modal_windows_server
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Client-side implementation of modal windows BUG=548402 Committed: https://crrev.com/51a9d209df61e664f99d1a9c4e53d8bb66741021 Cr-Commit-Position: refs/heads/master@{#380327}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added early out #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1 line) Patch
M components/mus/public/cpp/lib/in_flight_change.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M components/mus/public/cpp/window.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1759523002 Patch 200001

Messages

Total messages: 10 (4 generated)
mohsen
Please take a look...
4 years, 9 months ago (2016-03-09 22:57:52 UTC) #2
sky
LGTM https://codereview.chromium.org/1784573002/diff/1/components/mus/public/cpp/lib/window.cc File components/mus/public/cpp/lib/window.cc (right): https://codereview.chromium.org/1784573002/diff/1/components/mus/public/cpp/lib/window.cc#newcode350 components/mus/public/cpp/lib/window.cc:350: LocalSetModal(); Early out if already modal.
4 years, 9 months ago (2016-03-10 00:21:43 UTC) #3
mohsen
https://codereview.chromium.org/1784573002/diff/1/components/mus/public/cpp/lib/window.cc File components/mus/public/cpp/lib/window.cc (right): https://codereview.chromium.org/1784573002/diff/1/components/mus/public/cpp/lib/window.cc#newcode350 components/mus/public/cpp/lib/window.cc:350: LocalSetModal(); On 2016/03/10 at 00:21:43, sky wrote: > Early ...
4 years, 9 months ago (2016-03-10 03:23:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784573002/20001
4 years, 9 months ago (2016-03-10 03:48:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-10 04:00:26 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 04:02:06 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/51a9d209df61e664f99d1a9c4e53d8bb66741021
Cr-Commit-Position: refs/heads/master@{#380327}

Powered by Google App Engine
This is Rietveld 408576698