Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1784563002: unify peekPixels around pixmap parameter (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
bsalomon, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix android call-site, update ImageTest #

Patch Set 3 : update GrUploadPixmapToTexture to know about the new desc if readPixels was called #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -146 lines) Patch
M example/HelloWorld.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M gm/blend.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M include/core/SkCanvas.h View 1 chunk +9 lines, -6 lines 0 comments Download
M include/core/SkImage.h View 1 2 chunks +13 lines, -9 lines 0 comments Download
M include/core/SkSurface.h View 1 chunk +7 lines, -4 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +15 lines, -9 lines 0 comments Download
M src/core/SkSpecialImage.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 2 chunks +20 lines, -21 lines 0 comments Download
M src/image/SkImage_Base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Generator.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +3 lines, -9 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +17 lines, -1 line 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M tests/ImageTest.cpp View 1 2 5 chunks +9 lines, -19 lines 0 comments Download
M tests/SurfaceTest.cpp View 3 chunks +20 lines, -28 lines 0 comments Download
M tools/android/SkAndroidSDKCanvas.cpp View 1 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784563002/1
4 years, 9 months ago (2016-03-09 20:15:25 UTC) #4
reed1
4 years, 9 months ago (2016-03-09 20:15:29 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/6209)
4 years, 9 months ago (2016-03-09 20:20:37 UTC) #8
bsalomon
lgtm
4 years, 9 months ago (2016-03-09 20:25:22 UTC) #9
f(malita)
lgtm % androidsdkcanvas build fix
4 years, 9 months ago (2016-03-09 20:37:02 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784563002/20001
4 years, 9 months ago (2016-03-09 21:01:50 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/2012)
4 years, 9 months ago (2016-03-09 21:07:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784563002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784563002/20001
4 years, 9 months ago (2016-03-09 21:39:52 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/7520)
4 years, 9 months ago (2016-03-09 21:41:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784563002/40001
4 years, 9 months ago (2016-03-09 22:10:32 UTC) #23
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 22:26:30 UTC) #25
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/6ceeebd37a43d879c120b6ba100ae1febdd67a18

Powered by Google App Engine
This is Rietveld 408576698