Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: tests/ImageTest.cpp

Issue 1784553003: Fix Mac bots because of failing readback of 565 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: comment out unused function Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/ImageTest.cpp
diff --git a/tests/ImageTest.cpp b/tests/ImageTest.cpp
index 603a309acfc809f5eb1395ce269caa5769326add..ff1b4be5a65c2025d8fd1850806d0be94b1f0fca 100644
--- a/tests/ImageTest.cpp
+++ b/tests/ImageTest.cpp
@@ -68,12 +68,14 @@ static SkImage* create_image() {
draw_image_test_pattern(surface->getCanvas());
return surface->newImageSnapshot();
}
+#if 0
static SkImage* create_image_565() {
const SkImageInfo info = SkImageInfo::Make(20, 20, kRGB_565_SkColorType, kOpaque_SkAlphaType);
SkAutoTUnref<SkSurface> surface(SkSurface::NewRaster(info));
draw_image_test_pattern(surface->getCanvas());
return surface->newImageSnapshot();
}
+#endif
#if 0
static SkImage* create_image_ct() {
SkPMColor colors[] = {
@@ -805,10 +807,12 @@ static void check_images_same(skiatest::Reporter* reporter, const SkImage* a, co
DEF_GPUTEST_FOR_RENDERING_CONTEXTS(NewTextureFromPixmap, reporter, context) {
for (auto create : {&create_image,
+#if 0 // read pixels failing for non RT formats (565 not a RT on some desktop GLs).
&create_image_565
#if 0 // peekPixels on color table images is currently broken.
, &create_image_ct
#endif
+#endif
}) {
SkAutoTUnref<SkImage> image((*create)());
if (!image) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698