Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1784553002: Reland of Added ResourcePriorities field trial to the waterfall testing config (Closed)

Created:
4 years, 9 months ago by Pat Meenan
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Added ResourcePriorities field trial to the waterfall testing config (patchset #1 id:1 of https://codereview.chromium.org/1707723002/ ) Reason for revert: Re-landing now that a fix has landed: https://codereview.chromium.org/1783433003/ Original issue's description: > Revert of Added ResourcePriorities field trial to the waterfall testing config in preparation for launch (patchset #1 id:1 of https://codereview.chromium.org/1700253002/ ) > > Reason for revert: > Looks like the ResourcePriorities code is slowing down the service workers micro benchmark pretty significantly (and unexpectedly). Disabling it until we can understand and fix why. > > Original issue's description: > > Added ResourcePriorities field trial to the waterfall testing config in preparation for launch > > > > BUG=521744 > > > > Committed: https://crrev.com/64bc5ddf872133174294d6bbcd4536c06c8f6398 > > Cr-Commit-Position: refs/heads/master@{#375644} > > TBR=asvitkine@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=521744 > > Committed: https://crrev.com/37b8253bbb12ee475dc053a25ba3526c5c82ef99 > Cr-Commit-Position: refs/heads/master@{#375899} TBR=asvitkine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=521744 Committed: https://crrev.com/d093abb8ce20dbc64155e4ba5596380613412b2b Cr-Commit-Position: refs/heads/master@{#380220}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_linux.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_mac.json View 1 chunk +8 lines, -0 lines 0 comments Download
M testing/variations/fieldtrial_testing_config_win.json View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Pat Meenan
Created Reland of Added ResourcePriorities field trial to the waterfall testing config
4 years, 9 months ago (2016-03-09 20:10:59 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784553002/1
4 years, 9 months ago (2016-03-09 20:12:11 UTC) #3
Alexei Svitkine (slow)
lgtm
4 years, 9 months ago (2016-03-09 20:37:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-09 21:04:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784553002/1
4 years, 9 months ago (2016-03-09 21:13:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-09 21:19:08 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 21:21:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d093abb8ce20dbc64155e4ba5596380613412b2b
Cr-Commit-Position: refs/heads/master@{#380220}

Powered by Google App Engine
This is Rietveld 408576698