[Media Router] Add origins to sink query results.

chrome/browser/ui/webui/media_router/media_router_ui.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/media_router/media_router_ui.h"
 
 #include <algorithm>
 #include <string>
 #include <utility>
 
@@ skipping 246 matching lines @@
   collator_.reset(
       icu::Collator::createInstance(icu::Locale(locale.c_str()), error));
   if (U_FAILURE(error)) {
     DLOG(ERROR) << "Failed to create collator for locale " << locale;
     collator_.reset();
   }
 
   query_result_manager_.reset(new QueryResultManager(router_));
   query_result_manager_->AddObserver(this);
 
+  GURL origin = GetOrigin(false);
   // Desktop mirror mode is always available.
   query_result_manager_->StartSinksQuery(MediaCastMode::DESKTOP_MIRROR,
-                                         MediaSourceForDesktop());
+                                         MediaSourceForDesktop(), origin);
   initiator_ = initiator;
   SessionID::id_type tab_id = SessionTabHelper::IdForTab(initiator);
   if (tab_id != -1) {
     MediaSource mirroring_source(MediaSourceForTab(tab_id));
     query_result_manager_->StartSinksQuery(MediaCastMode::TAB_MIRROR,
-                                           mirroring_source);
+                                           mirroring_source, origin);
   }
   UpdateCastModes();
 }
 
 void MediaRouterUI::InitForTest(MediaRouter* router,
                                 content::WebContents* initiator,
                                 MediaRouterWebUIMessageHandler* handler) {
   router_ = router;
   handler_ = handler;
   InitCommon(initiator);
 }
 
 void MediaRouterUI::OnDefaultPresentationChanged(
     const PresentationRequest& presentation_request) {
   MediaSource source = presentation_request.GetMediaSource();
   presentation_request_.reset(new PresentationRequest(presentation_request));
-  query_result_manager_->StartSinksQuery(MediaCastMode::DEFAULT, source);
+  query_result_manager_->StartSinksQuery(MediaCastMode::DEFAULT, source,
+                                         GetOrigin(true));
   // Register for MediaRoute updates.
   routes_observer_.reset(new UIMediaRoutesObserver(
       router_, source.id(),
       base::Bind(&MediaRouterUI::OnRoutesUpdated, base::Unretained(this))));
 
   UpdateCastModes();
 }
 
 void MediaRouterUI::OnDefaultPresentationRemoved() {
   presentation_request_.reset();
@@ skipping 56 matching lines @@
   }
 
   bool for_default_source = cast_mode == MediaCastMode::DEFAULT;
   if (for_default_source && !presentation_request_) {
     DLOG(ERROR) << "Requested to create a route for presentation, but "
                 << "presentation request is missing.";
     return false;
   }
 
   current_route_request_id_ = ++route_request_counter_;
-  GURL origin;
-  if (for_default_source) {
-    origin = presentation_request_->frame_url().GetOrigin();
-  } else {
-    // Requesting route for mirroring. Use a placeholder URL as origin.
-    origin = GURL(chrome::kChromeUIMediaRouterURL);
-  }
+  GURL origin = GetOrigin(for_default_source);
   DCHECK(origin.is_valid());
 
   DVLOG(1) << "DoCreateRoute: origin: " << origin;
 
   // There are 3 cases. In all cases the MediaRouterUI will need to be notified.
   // (1) Non-presentation route request (e.g., mirroring). No additional
   // notification necessary.
   // (2) Presentation route request for a Presentation API startSession call.
   // The startSession (CreatePresentationConnectionRequest) will need to be
   // answered with the
@@ skipping 141 matching lines @@
               IssueAction(IssueAction::TYPE_DISMISS),
               std::vector<IssueAction>(), std::string(), Issue::NOTIFICATION,
               false, std::string());
   AddIssue(issue);
 }
 
 GURL MediaRouterUI::GetFrameURL() const {
   return presentation_request_ ? presentation_request_->frame_url() : GURL();
 }
 
+GURL MediaRouterUI::GetOrigin(bool for_default_source) const {

[mark a. foltz, 2016/03/11 01:20:23]

I don't think we need a method for this.  Just pass
GURL(chrome::kChromeUIMediaRouterURL).GetOrigin() or
presentation_request_->frame_url().GetOrigin() at the two call sites.

[imcheng, 2016/03/14 21:30:20]

Done.

+  DCHECK(!for_default_source || presentation_request_);
+  // Use a placeholder URL as origin for mirroring.
+  return for_default_source ? presentation_request_->frame_url().GetOrigin()
+                            : GURL(chrome::kChromeUIMediaRouterURL);
+}
+
 std::string MediaRouterUI::GetPresentationRequestSourceName() const {
   GURL gurl = GetFrameURL();
   return gurl.SchemeIs(extensions::kExtensionScheme)
              ? GetExtensionName(gurl, extensions::ExtensionRegistry::Get(
                                           Profile::FromWebUI(web_ui())))
              : GetHostFromURL(gurl);
 }
 
 std::string MediaRouterUI::GetTruncatedPresentationRequestSourceName() const {
   GURL gurl = GetFrameURL();
@@ skipping 27 matching lines @@
         base::Time::Now() - start_time_);
     start_time_ = base::Time();
   }
 }
 
 void MediaRouterUI::UpdateMaxDialogHeight(int height) {
   handler_->UpdateMaxDialogHeight(height);
 }
 
 }  // namespace media_router