Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 178453002: Add tests for sticky and various display values (Closed)

Created:
6 years, 10 months ago by rwlbuis
Modified:
6 years, 9 months ago
Reviewers:
ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add tests for sticky and various display values Add tests for sticky and various display values, tests should show up all green. BUG=231754 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168595

Patch Set 1 #

Patch Set 2 : Add description #

Total comments: 1

Patch Set 3 : Add more testcases #

Patch Set 4 : Improve tests #

Patch Set 5 : Make some items sticky #

Patch Set 6 : Add reftest expectations #

Patch Set 7 : Simplify grid and flexbox tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -35 lines) Patch
A + LayoutTests/fast/css/sticky/sticky-display.html View 1 2 3 chunks +30 lines, -10 lines 0 comments Download
A + LayoutTests/fast/css/sticky/sticky-display-expected.html View 1 4 chunks +28 lines, -8 lines 0 comments Download
A + LayoutTests/fast/css/sticky/sticky-flexbox.html View 1 2 3 4 5 6 2 chunks +38 lines, -17 lines 0 comments Download
A LayoutTests/fast/css/sticky/sticky-flexbox-expected.html View 1 2 3 4 5 6 1 chunk +83 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/sticky/sticky-grid.html View 1 2 3 4 5 6 1 chunk +92 lines, -0 lines 0 comments Download
A LayoutTests/fast/css/sticky/sticky-grid-expected.html View 1 2 3 4 5 6 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rwlbuis
I started on tests for display, let me know if I got the right idea ...
6 years, 10 months ago (2014-02-24 22:00:28 UTC) #1
rwlbuis
I started on tests for display, let me know if I got the right idea ...
6 years, 10 months ago (2014-02-24 22:00:29 UTC) #2
ojan
Some other cases that might be worth testing: -Flexbox where the sticky item's size and ...
6 years, 10 months ago (2014-02-25 00:51:29 UTC) #3
rwlbuis
On 2014/02/25 00:51:29, ojan wrote: > Some other cases that might be worth testing: > ...
6 years, 10 months ago (2014-02-26 23:45:50 UTC) #4
rwlbuis
Can you have a look at the latest tests? Willing to add more if needed.
6 years, 9 months ago (2014-02-27 21:19:54 UTC) #5
ojan
lgtm
6 years, 9 months ago (2014-03-05 23:25:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/178453002/120001
6 years, 9 months ago (2014-03-05 23:26:07 UTC) #7
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 08:10:12 UTC) #8
Message was sent while issue was closed.
Change committed as 168595

Powered by Google App Engine
This is Rietveld 408576698