Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: pkg/analysis_server/lib/src/analysis_server.dart

Issue 1784523002: Move more behavior out of ContextManagerCallbacks and into ContextManager (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/context_manager.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/analysis_server.dart
diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart
index cc068b3425ddb7457f82cef397ad02ad5cb90e2b..80afe0efe15bf43a91b25a9907e0ce56a1adca4e 100644
--- a/pkg/analysis_server/lib/src/analysis_server.dart
+++ b/pkg/analysis_server/lib/src/analysis_server.dart
@@ -330,8 +330,10 @@ class AnalysisServer {
options.enableIncrementalResolutionValidation;
defaultContextOptions.generateImplicitErrors = false;
operationQueue = new ServerOperationQueue();
+ sdkManager = new DartSdkManager(defaultSdkCreator);
contextManager = new ContextManagerImpl(
resourceProvider,
+ sdkManager,
packageResolverProvider,
embeddedResolverProvider,
packageMapProvider,
@@ -359,7 +361,6 @@ class AnalysisServer {
channel.sendNotification(notification);
channel.listen(handleRequest, onDone: done, onError: error);
handlers = serverPlugin.createDomains(this);
- sdkManager = new DartSdkManager(defaultSdkCreator);
}
/**
@@ -1565,11 +1566,7 @@ class ServerContextManagerCallbacks extends ContextManagerCallbacks {
}
@override
- void updateContextPackageUriResolver(
- Folder contextFolder, FolderDisposition disposition) {
- AnalysisContext context = analysisServer.folderMap[contextFolder];
- context.sourceFactory = _createSourceFactory(
- context, context.analysisOptions, disposition, contextFolder);
+ void updateContextPackageUriResolver(AnalysisContext context) {
analysisServer._onContextsChangedController
.add(new ContextsChangedEvent(changed: [context]));
analysisServer.schedulePerformAnalysisOperation(context);
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/context_manager.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698