Issue 1784523002: Move more behavior out of ContextManagerCallbacks and into ContextManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1784523002: Move more behavior out of ContextManagerCallbacks and into ContextManager (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson

Modified:
4 years, 9 months ago

Reviewers:
Paul Berry, scheglov

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -57 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	pkg/analysis_server/lib/src/context_manager.dart	View	9 chunks	+56 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/test/context_manager_test.dart	View	14 chunks	+40 lines, -46 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

Eventually the duplicated _createSourceFactory will be removed from ServerContextManagerCallbacks; I didn't do it this time ...

4 years, 9 months ago (2016-03-09 19:46:17 UTC) #2

Brian Wilkerson

4 years, 9 months ago (2016-03-10 16:36:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
83df52b590ae07e799302b46af0ade6f9666e16d (presubmit successful).