Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: src/gpu/batches/GrAADistanceFieldPathRenderer.cpp

Issue 1784493004: Reject dashes from GrAADFR (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/batches/GrAADistanceFieldPathRenderer.cpp
diff --git a/src/gpu/batches/GrAADistanceFieldPathRenderer.cpp b/src/gpu/batches/GrAADistanceFieldPathRenderer.cpp
index b585de963a97d1e4ab102bfe5d7742a44d687270..aec6606718b3d21569b0ba54550acdd7e090e2dc 100644
--- a/src/gpu/batches/GrAADistanceFieldPathRenderer.cpp
+++ b/src/gpu/batches/GrAADistanceFieldPathRenderer.cpp
@@ -109,7 +109,12 @@ bool GrAADistanceFieldPathRenderer::onCanDrawPath(const CanDrawPathArgs& args) c
}
maxDim += extraWidth;
}
-
+
+ // We don't currently apply the dash or factor it into the DF key.
+ if (args.fStroke->isDashed()) {
egdaniel 2016/03/11 01:00:52 any reason not to move this check up earlier to av
jvanverth1 2016/03/11 13:49:40 The first conditional block seems like a good plac
+ return false;
+ }
+
return maxDim <= kMediumMIP && maxDim * maxScale <= 2.0f*kLargeMIP;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698