Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1565)

Unified Diff: docs/closure_compilation.md

Issue 1784483003: Closure: attempt to fix up closure_compilation.md rendering (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@closure-doc
Patch Set: asdf Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/closure_compilation.md
diff --git a/docs/closure_compilation.md b/docs/closure_compilation.md
index 2c8fdcdcaf7cb1fde6469de173a5728f81b1bf84..7502d51cf747aef37c814d8601221f30716b674e 100644
--- a/docs/closure_compilation.md
+++ b/docs/closure_compilation.md
@@ -5,6 +5,7 @@
### Pre-requisites
You'll need Java 7 (preferably the OpenJDK version). To install on Ubuntu:
+
```shell
sudo apt-get install openjdk-7-jre
```
@@ -15,28 +16,33 @@ On Mac or Windows, visit:
### Using ninja to compile the code
We use GYP and ninja as our build system. To generate the ninja files from GYP:
+
```shell
# notice the 2 in compiled_resources.gyp
GYP_GENERATORS=ninja tools/gyp/gyp --depth . third_party/closure_compiler/compiled_resources2.gyp
```
To compile the JavaScript:
+
```shell
ninja -C out/Default -j4
```
The output should look something like this:
+
```shell
ninja: Entering directory `out/Default/'
[30/106] ACTION Compiling chrome/browser/resources/md_history/constants.js
```
To generate and run the **deprecated** v1 gyp format, remove the "2" from "compiled_resources2.gyp":
+
```shell
$ GYP_GENERATORS=ninja tools/gyp/gyp --depth . third_party/closure_compiler/compiled_resources.gyp
```
Compiling works the same way for both v1 and v2 systems:
+
```shell
ninja -C out/Default -j4
```
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698