Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 1784433003: Track CTR of uncommon download warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add one more test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h
index 79bd618f4bd37db1fd7f18fac588d9c1ad2b5704..3afd0ad37c1a9152a9db7a734283ff1c6b4adec8 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.h
+++ b/chrome/browser/safe_browsing/safe_browsing_service.h
@@ -175,8 +175,8 @@ class SafeBrowsingService
scoped_ptr<StateSubscription> RegisterStateCallback(
const base::Callback<void(void)>& callback);
- // Sends serialized download recovery report to backend.
- virtual void SendDownloadRecoveryReport(const std::string& report);
+ // Sends serialized download report to backend.
+ virtual void SendSerializedDownloadReport(const std::string& report);
protected:
// Creates the safe browsing service. Need to initialize before using.
@@ -189,6 +189,9 @@ class SafeBrowsingService
virtual SafeBrowsingUIManager* CreateUIManager();
#if defined(FULL_SAFE_BROWSING)
+ virtual DownloadProtectionService* CreateDownloadProtectionService(
+ net::URLRequestContextGetter* request_context_getter);
+
virtual IncidentReportingService* CreateIncidentReportingService();
#endif
@@ -244,7 +247,7 @@ class SafeBrowsingService
// starts or stops the service accordingly.
void RefreshState();
- void OnSendDownloadRecoveryReport(const std::string& report);
+ void OnSendSerializedDownloadReport(const std::string& report);
// The factory used to instanciate a SafeBrowsingService object.
// Useful for tests, so they can provide their own implementation of

Powered by Google App Engine
This is Rietveld 408576698