Track CTR of uncommon download warning.

chrome/browser/download/download_commands.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_commands.h"
 
 #include <stdint.h>
 
 #include "base/base64.h"
 #include "base/files/file_util.h"
 #include "base/macros.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/download/download_crx_util.h"
 #include "chrome/browser/download/download_extensions.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/image_decoder.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/safe_browsing/download_protection_service.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
+#include "chrome/common/safe_browsing/csd.pb.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/google/core/browser/google_util.h"
 #include "components/mime_util/mime_util.h"
 #include "grit/theme_resources.h"
 #include "net/base/url_util.h"
 #include "ui/base/clipboard/scoped_clipboard_writer.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
@@ skipping 235 matching lines @@
     case PLATFORM_OPEN:
       DownloadItemModel(download_item_).OpenUsingPlatformHandler();
       break;
     case CANCEL:
       download_item_->Cancel(true /* Cancelled by user */);
       break;
     case DISCARD:
       download_item_->Remove();
       break;
     case KEEP:
+    // Only sends uncommon download accept report if :
+    // 1. FULL_SAFE_BROWSING is enabled, and
+    // 2. Download verdict is uncommon, and
+    // 3. Download URL is not empty, and
+    // 4. User is not in incognito mode.
+#if defined(FULL_SAFE_BROWSING)
+      if (download_item_->GetDangerType() ==
+              content::DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT &&

[Nathan Parker, 2016/03/17 17:33:12]

Remind me why this is just for uncommon downloads, and not for uws/malware?

[Nathan Parker, 2016/03/17 17:34:39]

Nevermind, just figured it out (only uncommon has "keep" button).

[Jialiu Lin, 2016/03/17 20:14:44]

Yes, only uncommon has keep button.

+          !download_item_->GetURL().is_empty() &&
+          !download_item_->GetBrowserContext()->IsOffTheRecord()) {
+        safe_browsing::SafeBrowsingService* sb_service =
+            g_browser_process->safe_browsing_service();
+        // Compiles the uncommon download warning report.
+        safe_browsing::ClientSafeBrowsingReportRequest report;
+        report.set_type(safe_browsing::ClientSafeBrowsingReportRequest::
+                            DANGEROUS_DOWNLOAD_WARNING);
+        report.set_download_verdict(
+            safe_browsing::ClientDownloadResponse::UNCOMMON);
+        report.set_url(download_item_->GetURL().spec());
+        report.set_did_proceed(true);
+        std::string serialized_report;
+        if (report.SerializeToString(&serialized_report))
+          sb_service->SendSerializedDownloadReport(serialized_report);
+        else
+          DLOG(ERROR)

[Nathan Parker, 2016/03/17 17:33:12]

nit: if/else code > 1 line should have {}'s

You could instead DCHECK(false) << ".." since this should make any debug tests
fail quickly -- it means the proto has required fields you're not setting, which
we should catch right away.

[Jialiu Lin, 2016/03/17 20:14:44]

Done

+              << "Unable to serialize the uncommon download warning report.";
+      }
+#endif
       download_item_->ValidateDangerousDownload();
       break;
     case LEARN_MORE_SCANNING: {
 #if defined(FULL_SAFE_BROWSING)
       using safe_browsing::DownloadProtectionService;
 
       safe_browsing::SafeBrowsingService* sb_service =
           g_browser_process->safe_browsing_service();
       DownloadProtectionService* protection_service =
           (sb_service ? sb_service->download_protection_service() : nullptr);
@@ skipping 70 matching lines @@
                                                 &mime) ||
         !mime_util::IsSupportedImageMimeType(mime)) {
       // It seems a non-image file.
       return;
     }
   }
 
   base::FilePath file_path = download_item_->GetFullPath();
   ImageClipboardCopyManager::Start(file_path);
 }