Include isolate.py in data for Android unit tests

build/print-python-deps.py

+#!/usr/bin/env python

[jbudorick, 2016/03/24 17:44:51]

Nit: print_python_deps.py instead of print-python-deps.py.

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Prints all non-system dependencies for the given module.
+
+The primary use-case for this script is to genererate the list of python modules
+required for .isolate files.
+"""
+
+import argparse
+import imp
+import os
+import pipes
+import sys
+
+# Don't use any helper modules, or else they will end up in the results.
+
+
+_SRC_ROOT = os.path.abspath(os.path.join(__file__, os.pardir, os.pardir))

[jbudorick, 2016/03/24 17:44:51]

nit:

  os.path.dirname(__file__), os.pardir

instead of

  __file__, os.pardir, os.pardir

[agrieve, 2016/03/24 18:47:39]

Done.

+
+
+def ComputePythonDependencies(root):
+  """Gets the paths of imported non-system python modules.
+
+  A path is assumed to be a "system" import if it is outside of chromium's
+  src/. The paths will be relative to the current directory.
+  """
+  module_paths = (m.__file__ for m in sys.modules.values()
+                  if m is not None and hasattr(m, '__file__'))

[jbudorick, 2016/03/24 17:44:51]

nit: Do you need to check against None specifically, or can this just be

  if m and hasattr(m, '__file__')

[agrieve, 2016/03/24 18:47:38]

Done.

+
+  src_paths = set()
+  for path in module_paths:
+    if path == __file__:
+      continue
+    path = os.path.abspath(path)
+    if not path.startswith(_SRC_ROOT):
+      continue
+
+    if path.endswith('.pyc'):
+      path = path[:-1]
+    src_paths.add(os.path.relpath(path, root))
+
+  return sorted(src_paths)
+
+
+def main():
+  parser = argparse.ArgumentParser(
+      description='Prints all non-system dependencies for the given module.')
+  parser.add_argument('module',
+                      help='The python module to analyze.')
+  parser.add_argument('--root', default='.',
+                      help='Directory to make paths relative to.')
+  parser.add_argument('--output',
+                      help='Write output to a file rather than stdout.')
+  options = parser.parse_args()
+  sys.path.append(os.path.dirname(options.module))
+  imp.load_source('NAME', options.module)
+  out = open(options.output, 'w') if options.output else sys.stdout

[jbudorick, 2016/03/24 17:44:51]

This file should be closed after you're done writing to it.

[agrieve, 2016/03/24 18:47:39]

Done.

+  out.write('# Generated by //build/print-python-deps.py\n')
+  out.write('# root: //%s\n' % os.path.relpath(options.root, _SRC_ROOT))
+  out.write('# target: //%s\n' % os.path.relpath(options.module, _SRC_ROOT))
+  for path in ComputePythonDependencies(options.root):
+    out.write(path + "\n")

[jbudorick, 2016/03/24 17:44:51]

nit: single quotes

[agrieve, 2016/03/24 18:47:38]

Done.

+
+
+if __name__ == '__main__':
+  sys.exit(main())