Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1784343004: [wasm] Refactor tests for i64. (Closed)

Created:
4 years, 9 months ago by titzer
Modified:
4 years, 9 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Refactor tests for i64. Move all tests that use i64 values into test-run-wasm-64.cc. Introduce macros that enable tests as they are implemented on 32 bit platforms. R=ahaas@chromium.org BUG= Committed: https://crrev.com/4233050f771eafff41657137ea1d19350ebcbb98 Cr-Commit-Position: refs/heads/master@{#34742}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+702 lines, -557 lines) Patch
M test/cctest/wasm/test-run-wasm.cc View 1 2 3 10 chunks +6 lines, -524 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 2 3 4 21 chunks +696 lines, -33 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
PTAL. This makes testing more robust and clearer what is enabled and what is not.
4 years, 9 months ago (2016-03-14 11:08:18 UTC) #1
ahaas
lgtm
4 years, 9 months ago (2016-03-14 13:14:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784343004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784343004/80001
4 years, 9 months ago (2016-03-14 13:22:10 UTC) #4
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-14 13:23:50 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 13:24:44 UTC) #7
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4233050f771eafff41657137ea1d19350ebcbb98
Cr-Commit-Position: refs/heads/master@{#34742}

Powered by Google App Engine
This is Rietveld 408576698