Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Side by Side Diff: xfa.gyp

Issue 1784323006: Re-enable warning 4201 for xfa and other clean up (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: remove tags Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | xfa/fxgraphics/fx_graphics.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 { 1 {
2 "variables": { 2 "variables": {
3 "pdf_enable_v8%": 1, 3 "pdf_enable_v8%": 1,
4 }, 4 },
5 "target_defaults": { 5 "target_defaults": {
6 "defines": [ 6 "defines": [
7 "PDF_ENABLE_XFA", 7 "PDF_ENABLE_XFA",
8 ], 8 ],
9 'msvs_disabled_warnings': [ 9 'msvs_disabled_warnings': [
10 4005, 4018, 4146, 4333, 4345, 4267, 10 4005, 4018, 4146, 4333, 4345, 4267,
11 # TODO(ochang): Investigate if this can be fixed properly.
12 4201,
13 # TODO(thestig): Fix all instances, remove this, pdfium:29 11 # TODO(thestig): Fix all instances, remove this, pdfium:29
14 4245, 4310, 4389, 4701, 4702, 4706, 4800, 12 4245, 4310, 4389, 4701, 4702, 4706, 4800,
15 ], 13 ],
16 'variables': { 14 'variables': {
17 'clang_warning_flags': [ 15 'clang_warning_flags': [
18 # TODO(thestig): Fix all instances, remove this, pdfium:29 16 # TODO(thestig): Fix all instances, remove this, pdfium:29
19 '-Wno-sign-compare', 17 '-Wno-sign-compare',
20 ], 18 ],
21 # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux. 19 # Make sure Chromium's build/common.gypi doesn't re-add the flag on linux.
22 'cflags_cc!': [ '-Wsign-compare' ], 20 'cflags_cc!': [ '-Wsign-compare' ],
(...skipping 672 matching lines...) Expand 10 before | Expand all | Expand 10 after
695 "sources": [], 693 "sources": [],
696 }], 694 }],
697 ["OS == 'mac'", { 695 ["OS == 'mac'", {
698 "configurations": {}, 696 "configurations": {},
699 "sources": [], 697 "sources": [],
700 }], 698 }],
701 ] 699 ]
702 } 700 }
703 ] 701 ]
704 } 702 }
OLDNEW
« no previous file with comments | « no previous file | xfa/fxgraphics/fx_graphics.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698