Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Issue 1784263002: dart2js cps: A few extra RTI optimizations. (Closed)

Created:
4 years, 9 months ago by asgerf
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: A few extra RTI optimizations. There is no need to set the runtime type on an object whose type arguments are all 'dynamic'. Also use a more precise precondition for eliminating a ReadTypeVariable access. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/fafed299ca91e859ebbb5285508fdc32b68b02ad

Patch Set 1 #

Patch Set 2 : Fix negation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/gvn.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
asgerf
4 years, 9 months ago (2016-03-11 12:30:59 UTC) #3
Kevin Millikin (Google)
LGTM.
4 years, 9 months ago (2016-03-11 12:37:01 UTC) #4
asgerf
4 years, 9 months ago (2016-03-11 12:53:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fafed299ca91e859ebbb5285508fdc32b68b02ad (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698