Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1784203003: Adapt membrane example to ES6 proxies. (Closed)

Created:
4 years, 9 months ago by neis
Modified:
4 years, 9 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Adapt membrane example to ES6 proxies. R=rossberg BUG= Committed: https://crrev.com/f06f49c852feddfbc628e4ee3acc8699f47bef38 Cr-Commit-Position: refs/heads/master@{#34720}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -436 lines) Patch
M test/mjsunit/harmony/proxies-example-membrane.js View 2 chunks +236 lines, -432 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
neis
4 years, 9 months ago (2016-03-11 11:04:22 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784203003/1
4 years, 9 months ago (2016-03-11 11:48:21 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-11 12:06:12 UTC) #5
rossberg
lgtm LGTM, thanks!
4 years, 9 months ago (2016-03-11 12:50:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784203003/1
4 years, 9 months ago (2016-03-11 13:07:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 13:08:50 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 13:10:25 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f06f49c852feddfbc628e4ee3acc8699f47bef38
Cr-Commit-Position: refs/heads/master@{#34720}

Powered by Google App Engine
This is Rietveld 408576698