Avoid picking port 65535 for ServerSockets, when any is requested.

runtime/bin/socket_win.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "bin/builtin.h"
 #include "bin/eventhandler.h"
 #include "bin/file.h"
@@ skipping 357 matching lines @@
   status = bind(s,
                 &addr.addr,
                 SocketAddress::GetAddrLength(&addr));
   if (status == SOCKET_ERROR) {
     DWORD rc = WSAGetLastError();
     closesocket(s);
     SetLastError(rc);
     return -1;
   }
 
+  ListenSocket* listen_socket = new ListenSocket(s);
+
+  // Test for invalid socket port 65535 (some browsers disallow it).
+  if (port == 0 &&
+      Socket::GetPort(reinterpret_cast<intptr_t>(listen_socket)) == 65535) {
+    // Don't close fd until we have created new. By doing that we ensure another
+    // port.
+    intptr_t new_s = CreateBindListen(addr, 0, backlog, v6_only);
+    DWORD rc = WSAGetLastError();
+    closesocket(s);
+    delete listen_socket;
+    SetLastError(rc);
+    return new_s;
+  }
+
   status = listen(s, backlog > 0 ? backlog : SOMAXCONN);
   if (status == SOCKET_ERROR) {
     DWORD rc = WSAGetLastError();
     closesocket(s);
+    delete listen_socket;
     SetLastError(rc);
     return -1;
   }
 
-  ListenSocket* listen_socket = new ListenSocket(s);
   return reinterpret_cast<intptr_t>(listen_socket);
 }
 
 
 void Socket::Close(intptr_t fd) {
   ClientSocket* client_socket = reinterpret_cast<ClientSocket*>(fd);
   client_socket->Close();
 }
 
 
@@ skipping 26 matching lines @@
                     IPPROTO_TCP,
                     TCP_NODELAY,
                     reinterpret_cast<char *>(&on),
                     sizeof(on)) == 0;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)