Avoid picking port 65535 for ServerSockets, when any is requested.

runtime/bin/socket_macos.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_MACOS)
 
 #include <errno.h>  // NOLINT
 #include <stdio.h>  // NOLINT
 #include <stdlib.h>  // NOLINT
@@ skipping 304 matching lines @@
 
   SocketAddress::SetAddrPort(&addr, port);
   if (TEMP_FAILURE_RETRY(
           bind(fd,
                &addr.addr,
                SocketAddress::GetAddrLength(&addr))) < 0) {
     VOID_TEMP_FAILURE_RETRY(close(fd));
     return -1;
   }
 
+  // Test for invalid socket port 65535 (some browsers disallow it).
+  if (port == 0 && Socket::GetPort(fd) == 65535) {
+    // Don't close fd until we have created new. By doing that we ensure another
+    // port.

[Ivan Posva, 2013/06/27 01:08:55]

This comment is not clear. What you probably want to say is:
// Don't close the socket until we have created a new socket, ensuring that we
do not get the bad port number again.

[Anders Johnsen, 2013/06/27 16:35:57]

https://codereview.chromium.org/18087003/

+    intptr_t new_fd = CreateBindListen(addr, 0, backlog, v6_only);
+    int err = errno;
+    TEMP_FAILURE_RETRY(close(fd));

[Ivan Posva, 2013/06/27 01:08:55]

VOID_TEMP_FAILURE_RETRY

[Anders Johnsen, 2013/06/27 16:35:57]

I can see you committed this. Thanks.

+    errno = err;
+    return new_fd;
+  }
+
   if (TEMP_FAILURE_RETRY(listen(fd, backlog > 0 ? backlog : SOMAXCONN)) != 0) {
     VOID_TEMP_FAILURE_RETRY(close(fd));
     return -1;
   }
 
   Socket::SetNonBlocking(fd);
   return fd;
 }
 
 
@@ skipping 45 matching lines @@
                                        IPPROTO_TCP,
                                        TCP_NODELAY,
                                        reinterpret_cast<char *>(&on),
                                        sizeof(on))) == 0;
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_MACOS)