Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Side by Side Diff: media/renderers/default_renderer_factory.cc

Issue 1784173005: Request a GpuVideoAcceleratorFactories when constructing decoders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update test_mojo_media_client.cc Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/renderers/default_renderer_factory.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/renderers/default_renderer_factory.h" 5 #include "media/renderers/default_renderer_factory.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 16 matching lines...) Expand all
27 27
28 #if !defined(MEDIA_DISABLE_LIBVPX) 28 #if !defined(MEDIA_DISABLE_LIBVPX)
29 #include "media/filters/vpx_video_decoder.h" 29 #include "media/filters/vpx_video_decoder.h"
30 #endif 30 #endif
31 31
32 namespace media { 32 namespace media {
33 33
34 DefaultRendererFactory::DefaultRendererFactory( 34 DefaultRendererFactory::DefaultRendererFactory(
35 const scoped_refptr<MediaLog>& media_log, 35 const scoped_refptr<MediaLog>& media_log,
36 DecoderFactory* decoder_factory, 36 DecoderFactory* decoder_factory,
37 GpuVideoAcceleratorFactories* gpu_factories, 37 const GetGpuFactoriesCB& get_gpu_factories_cb,
38 const AudioHardwareConfig& audio_hardware_config) 38 const AudioHardwareConfig& audio_hardware_config)
39 : media_log_(media_log), 39 : media_log_(media_log),
40 decoder_factory_(decoder_factory), 40 decoder_factory_(decoder_factory),
41 gpu_factories_(gpu_factories), 41 get_gpu_factories_cb_(get_gpu_factories_cb),
42 audio_hardware_config_(audio_hardware_config) {} 42 audio_hardware_config_(audio_hardware_config) {}
43 43
44 DefaultRendererFactory::~DefaultRendererFactory() { 44 DefaultRendererFactory::~DefaultRendererFactory() {
45 } 45 }
46 46
47 ScopedVector<AudioDecoder> DefaultRendererFactory::CreateAudioDecoders( 47 ScopedVector<AudioDecoder> DefaultRendererFactory::CreateAudioDecoders(
48 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner) { 48 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner) {
49 // Create our audio decoders and renderer. 49 // Create our audio decoders and renderer.
50 ScopedVector<AudioDecoder> audio_decoders; 50 ScopedVector<AudioDecoder> audio_decoders;
51 51
52 #if !defined(MEDIA_DISABLE_FFMPEG) 52 #if !defined(MEDIA_DISABLE_FFMPEG)
53 audio_decoders.push_back( 53 audio_decoders.push_back(
54 new FFmpegAudioDecoder(media_task_runner, media_log_)); 54 new FFmpegAudioDecoder(media_task_runner, media_log_));
55 #endif 55 #endif
56 56
57 audio_decoders.push_back(new OpusAudioDecoder(media_task_runner)); 57 audio_decoders.push_back(new OpusAudioDecoder(media_task_runner));
58 58
59 if (decoder_factory_) 59 if (decoder_factory_)
60 decoder_factory_->CreateAudioDecoders(&audio_decoders); 60 decoder_factory_->CreateAudioDecoders(&audio_decoders);
61 61
62 return audio_decoders; 62 return audio_decoders;
63 } 63 }
64 64
65 ScopedVector<VideoDecoder> DefaultRendererFactory::CreateVideoDecoders( 65 ScopedVector<VideoDecoder> DefaultRendererFactory::CreateVideoDecoders(
66 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, 66 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
67 const RequestSurfaceCB& request_surface_cb) { 67 const RequestSurfaceCB& request_surface_cb,
68 GpuVideoAcceleratorFactories* gpu_factories) {
68 // Create our video decoders and renderer. 69 // Create our video decoders and renderer.
69 ScopedVector<VideoDecoder> video_decoders; 70 ScopedVector<VideoDecoder> video_decoders;
70 71
71 // |gpu_factories_| requires that its entry points be called on its 72 // |gpu_factories_| requires that its entry points be called on its
72 // |GetTaskRunner()|. Since |pipeline_| will own decoders created from the 73 // |GetTaskRunner()|. Since |pipeline_| will own decoders created from the
73 // factories, require that their message loops are identical. 74 // factories, require that their message loops are identical.
74 DCHECK(!gpu_factories_ || 75 DCHECK(!gpu_factories ||
75 (gpu_factories_->GetTaskRunner() == media_task_runner.get())); 76 (gpu_factories->GetTaskRunner() == media_task_runner.get()));
76 77
77 if (gpu_factories_) 78 if (gpu_factories)
78 video_decoders.push_back( 79 video_decoders.push_back(
79 new GpuVideoDecoder(gpu_factories_, request_surface_cb)); 80 new GpuVideoDecoder(gpu_factories, request_surface_cb));
80 81
81 #if !defined(MEDIA_DISABLE_LIBVPX) 82 #if !defined(MEDIA_DISABLE_LIBVPX)
82 video_decoders.push_back(new VpxVideoDecoder()); 83 video_decoders.push_back(new VpxVideoDecoder());
83 #endif 84 #endif
84 85
85 #if !defined(MEDIA_DISABLE_FFMPEG) && !defined(DISABLE_FFMPEG_VIDEO_DECODERS) 86 #if !defined(MEDIA_DISABLE_FFMPEG) && !defined(DISABLE_FFMPEG_VIDEO_DECODERS)
86 video_decoders.push_back(new FFmpegVideoDecoder()); 87 video_decoders.push_back(new FFmpegVideoDecoder());
87 #endif 88 #endif
88 89
89 if (decoder_factory_) 90 if (decoder_factory_)
90 decoder_factory_->CreateVideoDecoders(&video_decoders); 91 decoder_factory_->CreateVideoDecoders(&video_decoders);
91 92
92 return video_decoders; 93 return video_decoders;
93 } 94 }
94 95
95 scoped_ptr<Renderer> DefaultRendererFactory::CreateRenderer( 96 scoped_ptr<Renderer> DefaultRendererFactory::CreateRenderer(
96 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, 97 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
97 const scoped_refptr<base::TaskRunner>& worker_task_runner, 98 const scoped_refptr<base::TaskRunner>& worker_task_runner,
98 AudioRendererSink* audio_renderer_sink, 99 AudioRendererSink* audio_renderer_sink,
99 VideoRendererSink* video_renderer_sink, 100 VideoRendererSink* video_renderer_sink,
100 const RequestSurfaceCB& request_surface_cb) { 101 const RequestSurfaceCB& request_surface_cb) {
101 DCHECK(audio_renderer_sink); 102 DCHECK(audio_renderer_sink);
102 103
103 scoped_ptr<AudioRenderer> audio_renderer( 104 scoped_ptr<AudioRenderer> audio_renderer(
104 new AudioRendererImpl(media_task_runner, audio_renderer_sink, 105 new AudioRendererImpl(media_task_runner, audio_renderer_sink,
105 CreateAudioDecoders(media_task_runner), 106 CreateAudioDecoders(media_task_runner),
106 audio_hardware_config_, media_log_)); 107 audio_hardware_config_, media_log_));
107 108
109 GpuVideoAcceleratorFactories* gpu_factories = nullptr;
110 if (!get_gpu_factories_cb_.is_null())
111 gpu_factories = get_gpu_factories_cb_.Run();
112
108 scoped_ptr<VideoRenderer> video_renderer(new VideoRendererImpl( 113 scoped_ptr<VideoRenderer> video_renderer(new VideoRendererImpl(
109 media_task_runner, worker_task_runner, video_renderer_sink, 114 media_task_runner, worker_task_runner, video_renderer_sink,
110 CreateVideoDecoders(media_task_runner, request_surface_cb), true, 115 CreateVideoDecoders(media_task_runner, request_surface_cb, gpu_factories),
111 gpu_factories_, media_log_)); 116 true, gpu_factories, media_log_));
112 117
113 return scoped_ptr<Renderer>(new RendererImpl( 118 return scoped_ptr<Renderer>(new RendererImpl(
114 media_task_runner, std::move(audio_renderer), std::move(video_renderer))); 119 media_task_runner, std::move(audio_renderer), std::move(video_renderer)));
115 } 120 }
116 121
117 } // namespace media 122 } // namespace media
OLDNEW
« no previous file with comments | « media/renderers/default_renderer_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698