Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: media/renderers/default_renderer_factory.h

Issue 1784173005: Request a GpuVideoAcceleratorFactories when constructing decoders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | media/renderers/default_renderer_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_ 5 #ifndef MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_
6 #define MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_ 6 #define MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/scoped_vector.h" 10 #include "base/memory/scoped_vector.h"
11 #include "media/base/media_export.h" 11 #include "media/base/media_export.h"
12 #include "media/base/renderer_factory.h" 12 #include "media/base/renderer_factory.h"
13 13
14 namespace media { 14 namespace media {
15 15
16 class AudioDecoder; 16 class AudioDecoder;
17 class AudioHardwareConfig; 17 class AudioHardwareConfig;
18 class AudioRendererSink; 18 class AudioRendererSink;
19 class DecoderFactory; 19 class DecoderFactory;
20 class GpuVideoAcceleratorFactories; 20 class GpuVideoAcceleratorFactories;
21 class MediaLog; 21 class MediaLog;
22 class VideoDecoder; 22 class VideoDecoder;
23 class VideoRendererSink; 23 class VideoRendererSink;
24 24
25 // The default factory class for creating RendererImpl. 25 // The default factory class for creating RendererImpl.
26 class MEDIA_EXPORT DefaultRendererFactory : public RendererFactory { 26 class MEDIA_EXPORT DefaultRendererFactory : public RendererFactory {
27 public: 27 public:
28 DefaultRendererFactory(const scoped_refptr<MediaLog>& media_log, 28 DefaultRendererFactory(
29 DecoderFactory* decoder_factory, 29 const scoped_refptr<MediaLog>& media_log,
30 GpuVideoAcceleratorFactories* gpu_factories, 30 DecoderFactory* decoder_factory,
31 const AudioHardwareConfig& audio_hardware_config); 31 base::Callback<GpuVideoAcceleratorFactories*()> get_gpu_factories_cb,
DaleCurtis 2016/03/11 23:46:20 const&?
sandersd (OOO until July 31) 2016/03/11 23:56:22 Done.
32 const AudioHardwareConfig& audio_hardware_config);
32 ~DefaultRendererFactory() final; 33 ~DefaultRendererFactory() final;
33 34
34 scoped_ptr<Renderer> CreateRenderer( 35 scoped_ptr<Renderer> CreateRenderer(
35 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, 36 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
36 const scoped_refptr<base::TaskRunner>& worker_task_runner, 37 const scoped_refptr<base::TaskRunner>& worker_task_runner,
37 AudioRendererSink* audio_renderer_sink, 38 AudioRendererSink* audio_renderer_sink,
38 VideoRendererSink* video_renderer_sink, 39 VideoRendererSink* video_renderer_sink,
39 const RequestSurfaceCB& request_surface_cb) final; 40 const RequestSurfaceCB& request_surface_cb) final;
40 41
41 private: 42 private:
42 ScopedVector<AudioDecoder> CreateAudioDecoders( 43 ScopedVector<AudioDecoder> CreateAudioDecoders(
43 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner); 44 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner);
44 ScopedVector<VideoDecoder> CreateVideoDecoders( 45 ScopedVector<VideoDecoder> CreateVideoDecoders(
45 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner, 46 const scoped_refptr<base::SingleThreadTaskRunner>& media_task_runner,
46 const RequestSurfaceCB& request_surface_cb); 47 const RequestSurfaceCB& request_surface_cb,
48 GpuVideoAcceleratorFactories* gpu_factories);
47 49
48 scoped_refptr<MediaLog> media_log_; 50 scoped_refptr<MediaLog> media_log_;
49 51
50 // Factory to create extra audio and video decoders. 52 // Factory to create extra audio and video decoders.
51 // Could be nullptr if not extra decoders are available. 53 // Could be nullptr if not extra decoders are available.
52 DecoderFactory* decoder_factory_; 54 DecoderFactory* decoder_factory_;
53 55
54 // Factories for supporting video accelerators. May be null. 56 // Factories for supporting video accelerators. May be null.
55 GpuVideoAcceleratorFactories* gpu_factories_; 57 base::Callback<GpuVideoAcceleratorFactories*()> get_gpu_factories_cb_;
DaleCurtis 2016/03/11 23:46:20 Create typedef/using entry for the callback type.
sandersd (OOO until July 31) 2016/03/11 23:56:22 Done.
56 58
57 const AudioHardwareConfig& audio_hardware_config_; 59 const AudioHardwareConfig& audio_hardware_config_;
58 60
59 DISALLOW_COPY_AND_ASSIGN(DefaultRendererFactory); 61 DISALLOW_COPY_AND_ASSIGN(DefaultRendererFactory);
60 }; 62 };
61 63
62 } // namespace media 64 } // namespace media
63 65
64 #endif // MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_ 66 #endif // MEDIA_RENDERERS_DEFAULT_RENDERER_FACTORY_H_
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | media/renderers/default_renderer_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698