components/timers/alarm_timer_chromeos.cc - Issue 1784133002: [tracing] Adding task information to heap profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/timers/alarm_timer_chromeos.cc

Issue 1784133002: [tracing] Adding task information to heap profiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix macros again and the builds. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/timers/alarm_timer_chromeos.cc

diff --git a/components/timers/alarm_timer_chromeos.cc b/components/timers/alarm_timer_chromeos.cc

index 0cb25fafd876312d40cb27fb572e0b7037ddc747..d0ba76933f950a50a0bbfb13d0e97ab5e108999e 100644

--- a/components/timers/alarm_timer_chromeos.cc

+++ b/components/timers/alarm_timer_chromeos.cc

@@ -434,7 +434,7 @@ void AlarmTimer::OnTimerFired() {

else

Stop();

- TRACE_TASK_EXECUTION("AlarmTimer::OnTimerFired", *pending_user_task);

+ TRACE_TASK_EXECUTION("AlarmTimer::OnTimerFired", (*pending_user_task));

Primiano Tucci (use gerrit) 2016/03/31 15:37:16 why do we need parentheses here? smells like we ne

Nico 2016/03/31 16:12:48 yup, +1

ssid 2016/04/01 04:34:54 yes, I was thinking it is better to add here inste

// Now run the user task.

base::MessageLoop::current()->task_annotator()->RunTask("AlarmTimer::Reset",