[tracing] Adding task information to heap profiler

base/debug/task_annotator.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_DEBUG_TASK_ANNOTATOR_H_
 #define BASE_DEBUG_TASK_ANNOTATOR_H_
 
 #include <stdint.h>
 
 #include "base/base_export.h"
 #include "base/macros.h"
+#include "base/trace_event/heap_profiler_allocation_context_tracker.h"
 
 namespace base {
 struct PendingTask;
 namespace debug {
 
 // Implements common debug annotations for posted tasks. This includes data
 // such as task origins, queueing durations and memory usage.
 class BASE_EXPORT TaskAnnotator {
  public:
   TaskAnnotator();
@@ skipping 10 matching lines @@
 
  private:
   // Creates a process-wide unique ID to represent this task in trace events.
   // This will be mangled with a Process ID hash to reduce the likelyhood of
   // colliding with TaskAnnotator pointers on other processes.
   uint64_t GetTaskTraceID(const PendingTask& task) const;
 
   DISALLOW_COPY_AND_ASSIGN(TaskAnnotator);
 };
 
-#define TRACE_TASK_EXECUTION(run_function, task)           \
-  TRACE_EVENT2("toplevel", (run_function), "src_file",     \
-               (task).posted_from.file_name(), "src_func", \
-               (task).posted_from.function_name());
+#define TRACE_TASK_EXECUTION(run_function, task)                               \
+  TRACE_EVENT2("toplevel", (run_function), "src_file",                         \
+               (task).posted_from.file_name(), "src_func",                     \
+               (task).posted_from.function_name());                            \
+  base::trace_event::AllocationContextTracker::ScopedTaskExecutionEvent event( \

[Primiano Tucci (use gerrit), 2016/03/25 01:56:31]

I'd use a name which tries to avoid conflics.
Also, to be honest I think that either:
- this entire macro should really be inside trace_event.h. There you could use
INTERNAL_TRACE_EVENT_UID to mangle the name for the event variable.
or
- ScopedTaskExecutionEvent should be a class inside task_annotator.h, and make
the push methods public in the tracker

[ssid, 2016/03/28 18:14:49]

yes I think its a good idea to move it to trace_event.h. Lets see what others
think about this.

If I add it here, I would have to explain about why task execution is special
case what is heap profiler and stuff to the base/debug owners, it is easier to
explain to trace_event/ folks.

+      (task).posted_from.file_name(), (task).posted_from.function_name());

[Primiano Tucci (use gerrit), 2016/03/25 01:56:31]

Looks like you never use the second argument. Why bothering passing that?

[ssid, 2016/03/28 18:14:49]

I was hoping I will need it soon and I will have to change this file again,
asking other people. Now its inside trace_event/ can change later when needed.

 
 }  // namespace debug
 }  // namespace base
 
 #endif  // BASE_DEBUG_TASK_ANNOTATOR_H_