Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Issue 178413003: Fix ChromeOS build broken in f84722e4777 (Closed)

Created:
6 years, 10 months ago by hal.canary
Modified:
6 years, 10 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix ChromeOS build broken in f84722e4777 NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13571

Patch Set 1 #

Total comments: 2

Patch Set 2 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/images.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hal.canary
6 years, 10 months ago (2014-02-24 20:47:40 UTC) #1
scroggo
https://codereview.chromium.org/178413003/diff/1/gyp/images.gyp File gyp/images.gyp (right): https://codereview.chromium.org/178413003/diff/1/gyp/images.gyp#newcode165 gyp/images.gyp:165: 'libpng.gyp:libpng', Should this go into chromeos_deps? I think it's ...
6 years, 10 months ago (2014-02-24 20:52:52 UTC) #2
hal.canary
https://codereview.chromium.org/178413003/diff/1/gyp/images.gyp File gyp/images.gyp (right): https://codereview.chromium.org/178413003/diff/1/gyp/images.gyp#newcode165 gyp/images.gyp:165: 'libpng.gyp:libpng', On 2014/02/24 20:52:52, scroggo wrote: > Should this ...
6 years, 10 months ago (2014-02-24 21:05:10 UTC) #3
scroggo
On 2014/02/24 21:05:10, Hal Canary wrote: > https://codereview.chromium.org/178413003/diff/1/gyp/images.gyp > File gyp/images.gyp (right): > > https://codereview.chromium.org/178413003/diff/1/gyp/images.gyp#newcode165 ...
6 years, 10 months ago (2014-02-24 21:38:11 UTC) #4
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 10 months ago (2014-02-24 21:38:20 UTC) #5
hal.canary
The CQ bit was unchecked by halcanary@google.com
6 years, 10 months ago (2014-02-24 21:38:23 UTC) #6
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 10 months ago (2014-02-24 21:38:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/178413003/40001
6 years, 10 months ago (2014-02-24 21:38:56 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-24 21:39:05 UTC) #9
Message was sent while issue was closed.
Change committed as 13571

Powered by Google App Engine
This is Rietveld 408576698