Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1784043002: Reland of Use gclient's git_cache setting in bot_update/api.py (Closed)

Created:
4 years, 9 months ago by martiniss
Modified:
4 years, 9 months ago
Reviewers:
iannucci, szager1
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland of Use gclient's git_cache setting in bot_update/api.py https://codereview.chromium.org/1762513002/ Use gclient's git_cache setting in bot_update/api.py BUG=589140 R=szager@chromium.org,iannucci@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299260

Patch Set 1 #

Patch Set 2 : No dependent patchset? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M recipe_modules/bot_update/api.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
martiniss
PTAL (won't commit until I test the change further, however)
4 years, 9 months ago (2016-03-11 00:42:57 UTC) #1
iannucci
stamp lgtm, but let's be careful about downstream first
4 years, 9 months ago (2016-03-11 00:43:59 UTC) #2
szager1
lgtm
4 years, 9 months ago (2016-03-11 00:59:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784043002/20001
4 years, 9 months ago (2016-03-12 00:22:26 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 00:24:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299260

Powered by Google App Engine
This is Rietveld 408576698