Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1784033002: Remove --harmony-tostring runtime flag (Closed)

Created:
4 years, 9 months ago by adamk
Modified:
4 years, 9 months ago
Reviewers:
Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove --harmony-tostring runtime flag ES2015 Object.prototype.toString semantics were enabled in version 4.9, which has been in stable Chrome for nearly two weeks at this point. R=littledan@chromium.org Committed: https://crrev.com/b16fc86389c3cafa76a53744d1bacd756ec528cb Cr-Commit-Position: refs/heads/master@{#34732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -65 lines) Patch
M src/bootstrapper.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/messages.js View 3 chunks +2 lines, -12 lines 0 comments Download
M src/js/symbol.js View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.cc View 2 chunks +11 lines, -15 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M test/mjsunit/compare-known-objects-tostringtag.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/array-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/array-tostring.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/built-in-accessor-names.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/collection-iterator.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/collections.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/generators-objects.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/json.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/math.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/object-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/promises.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/string-iterator.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/typedarray.js View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/sharedarraybuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/simd.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
adamk
4 years, 9 months ago (2016-03-11 00:29:52 UTC) #1
Dan Ehrenberg
lgtm
4 years, 9 months ago (2016-03-11 01:30:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784033002/1
4 years, 9 months ago (2016-03-11 01:40:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_win64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/4310) v8_win64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-11 02:19:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784033002/1
4 years, 9 months ago (2016-03-11 17:57:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 18:19:10 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 18:20:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b16fc86389c3cafa76a53744d1bacd756ec528cb
Cr-Commit-Position: refs/heads/master@{#34732}

Powered by Google App Engine
This is Rietveld 408576698